-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sections for evals and use cases; cite evals appropriately; update methods considered table #50
Conversation
Signed-off-by: dhh1128 <[email protected]>
Signed-off-by: dhh1128 <[email protected]>
Signed-off-by: dhh1128 <[email protected]>
Signed-off-by: dhh1128 <[email protected]>
Co-authored-by: Ted Thibodeau Jr <[email protected]>
Co-authored-by: Ted Thibodeau Jr <[email protected]>
Co-authored-by: Ted Thibodeau Jr <[email protected]>
@dhh1128 Looks like we have an error in the CI/CD tooling. It is likely because of a couple of missing Alternatively, merge in #49 and pull main back into your PR. That would probably clean it up with less likelihood of a merge conflict. |
@jandrieu -- You need to codefence the HTML tags in your comment, to make them visible to readers. |
This is stumping the editors and blocking other merges and action right now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe my two suggested changes will resolve the build error, and remove a tiny errant snippet of text.
Signed-off-by: dhh1128 <[email protected]>
Signed-off-by: Daniel Hardman <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changes look good.
This looks good. Merging. |
Looks like the edits from this merge got smushed. @rxgrant Let's review and figure out how to get the evaluation citations and related metadata back into the document. |
@rxgrant and I found that this was a synchronization problem between the main branch, the github.io version, and the /TR version. We removed the hardcoded publication date (August 26) from the index.html and that eventually got us an updated github.io page, but the TR has not yet updated. We're going to give it another day to see if the TR updates, but we are also baffled as to why the date in the html would prevent github pages from rendering a new .io page. When we removed the date, it didn't just give us the correct date, it actually pulled in the latest version. How and why that happens seems to be buried in the github pages configuration. @iherman Can you advise about how we should be doing this? I think we aren't quite configured right for auto publishing and I expect our hack of removing the date may not be the "right" way. |
There seem to be some system problems. I have updated the github action script but that did not solve all the issues. See my mail sent to the powers to be (I cc-d you because I was not sure that you can access that archive). Sigh... |
Preview | Diff