-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove some deprecated attributes #5
Comments
|
These attributes are currently not in MathML Core, so this is just for MathML 4. |
We agreed on 2019-02-25 that currently deprecated attributes should not go into MathML Core: https://lists.w3.org/Archives/Public/public-mathml4/2019Feb/0048.html I checked the spec & schema and cannot find any of the attributes listed in #5 (comment) We still need to:
Note: some deprecated attributes might still be used like font or colors (e.g. https://bugzilla.mozilla.org/show_bug.cgi?id=1027354 ). Others have never been implemented or have already been removed without complaints ( e.g. namedspace attributes ). Also, "mathvariant" is supposed to take precedent over the deprecated attributes "fontweight" and "fontstyle". In term of CSS, that means that mathvariant has to reset font-style/font-weight to avoid weird results. There are some hacks in Gecko/Stylo that can be removed once we get rid of "fontweight" and "fontstyle". |
From https://lists.w3.org/Archives/Public/public-mathml4/2019Mar/0026.html
|
Resolution: Specification: Implementation: Polyfill: Tests:
|
These are not in core per #5 (comment) ; @davidcarlisle please check the full spec and do the necessary change, if any. |
The mode attribute has been removed from Gecko: https://bugzilla.mozilla.org/show_bug.cgi?id=1573438 (WebKit has never implemented it) Polyfill:
|
See w3c/mathml#5 (comment) and https://groups.google.com/forum/#!topic/mozilla.dev.platform/kl5c87mBlO0 This patch introduces a new preference mathml.deprecated_style_attributes.disabled in order to disable legacy support for attributes background, color, fontfamily, fontsize, fontstyle and fontweight. Note that xlink:href will be handled separately in bug 1575870. * A new counter and deprecation message is introduced for these attributes. In nsMathMLElement, the old WarnDeprecated calls are replaced with a single call to WarnOnceAbout for the deprecate attributes. Notice that for some reason, the color attribute used to send warning in both ParseAttribute and MapMathMLAttributesInto. * sMtableStyles is removed and replaced with a simple comparison. * sMathML3Attributes is split into two tables: one for script attributes which will be handled in bug 1548471 and one for style attributes, handled here. The attributes in this second table is now ignored when the feature flag is disabled. * test_bug553917.html is updated so that it no longer checks the old warning messages for these attributes. New warning messages have been verified manually. * Reftests checking support for these attributes are run with the support enabled. * Finally, WPT tests are run with the support disabled and a new test is added to verify that these attributes are no longer mapped to CSS. Differential Revision: https://phabricator.services.mozilla.com/D43111 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1548524 gecko-commit: 69105b8565ce19ceb8c26757d0a81138854f1d13 gecko-integration-branch: autoland gecko-reviewers: emilio
See w3c/mathml#5 (comment) and https://groups.google.com/forum/#!topic/mozilla.dev.platform/kl5c87mBlO0 This patch introduces a new preference mathml.deprecated_style_attributes.disabled in order to disable legacy support for attributes background, color, fontfamily, fontsize, fontstyle and fontweight. Note that xlink:href will be handled separately in bug 1575870. * A new counter and deprecation message is introduced for these attributes. In nsMathMLElement, the old WarnDeprecated calls are replaced with a single call to WarnOnceAbout for the deprecate attributes. Notice that for some reason, the color attribute used to send warning in both ParseAttribute and MapMathMLAttributesInto. * sMtableStyles is removed and replaced with a simple comparison. * sMathML3Attributes is split into two tables: one for script attributes which will be handled in bug 1548471 and one for style attributes, handled here. The attributes in this second table is now ignored when the feature flag is disabled. * test_bug553917.html is updated so that it no longer checks the old warning messages for these attributes. New warning messages have been verified manually. * Reftests checking support for these attributes are run with the support enabled. * Finally, WPT tests are run with the support disabled and a new test is added to verify that these attributes are no longer mapped to CSS. Differential Revision: https://phabricator.services.mozilla.com/D43111 --HG-- extra : moz-landing-system : lando
See w3c/mathml#5 (comment) and https://groups.google.com/forum/#!topic/mozilla.dev.platform/kl5c87mBlO0 This patch introduces a new preference mathml.deprecated_style_attributes.disabled in order to disable legacy support for attributes background, color, fontfamily, fontsize, fontstyle and fontweight. Note that xlink:href will be handled separately in bug 1575870. * A new counter and deprecation message is introduced for these attributes. In nsMathMLElement, the old WarnDeprecated calls are replaced with a single call to WarnOnceAbout for the deprecate attributes. Notice that for some reason, the color attribute used to send warning in both ParseAttribute and MapMathMLAttributesInto. * sMtableStyles is removed and replaced with a simple comparison. * sMathML3Attributes is split into two tables: one for script attributes which will be handled in bug 1548471 and one for style attributes, handled here. The attributes in this second table is now ignored when the feature flag is disabled. * test_bug553917.html is updated so that it no longer checks the old warning messages for these attributes. New warning messages have been verified manually. * Reftests checking support for these attributes are run with the support enabled. * Finally, WPT tests are run with the support disabled and a new test is added to verify that these attributes are no longer mapped to CSS. Differential Revision: https://phabricator.services.mozilla.com/D43111 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1548524 gecko-commit: 69105b8565ce19ceb8c26757d0a81138854f1d13 gecko-integration-branch: autoland gecko-reviewers: emilio
See w3c/mathml#5 (comment) and https://groups.google.com/forum/#!topic/mozilla.dev.platform/kl5c87mBlO0 This patch introduces a new preference mathml.deprecated_style_attributes.disabled in order to disable legacy support for attributes background, color, fontfamily, fontsize, fontstyle and fontweight. Note that xlink:href will be handled separately in bug 1575870. * A new counter and deprecation message is introduced for these attributes. In nsMathMLElement, the old WarnDeprecated calls are replaced with a single call to WarnOnceAbout for the deprecate attributes. Notice that for some reason, the color attribute used to send warning in both ParseAttribute and MapMathMLAttributesInto. * sMtableStyles is removed and replaced with a simple comparison. * sMathML3Attributes is split into two tables: one for script attributes which will be handled in bug 1548471 and one for style attributes, handled here. The attributes in this second table is now ignored when the feature flag is disabled. * test_bug553917.html is updated so that it no longer checks the old warning messages for these attributes. New warning messages have been verified manually. * Reftests checking support for these attributes are run with the support enabled. * Finally, WPT tests are run with the support disabled and a new test is added to verify that these attributes are no longer mapped to CSS. Differential Revision: https://phabricator.services.mozilla.com/D43111
https://bugs.webkit.org/show_bug.cgi?id=197492 Patch by Rob Buis <[email protected]> on 2019-09-09 Reviewed by Frédéric Wang. LayoutTests/imported/w3c: Import relevant WPT test. * web-platform-tests/mathml/relations/css-styling/attribute-mapping-001-expected.txt: Added. * web-platform-tests/mathml/relations/css-styling/attribute-mapping-001.html: Added. Source/WebCore: Remove some MathML3 deprecated attributes: w3c/mathml#5 (comment) This change also maps the dir attribute to direction for MathML Core. Test: imported/w3c/web-platform-tests/mathml/relations/css-styling/attribute-mapping-001.html * mathml/MathMLElement.cpp: (WebCore::MathMLElement::collectStyleForPresentationAttribute): LayoutTests: Disable the MathML Core flag for tests assuming MathML3 behavior. * mathml/presentation/attributes-background-color-expected.html: * mathml/presentation/attributes-background-color.html: * mathml/presentation/attributes-mathvariant.html: * mathml/presentation/direction-overall.html: * mathml/presentation/mstyle-css-attributes.html: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@249645 268f45cc-cd09-0410-ab3c-d52691b4dbfc
|
We have removed support for namedspaces length values in #75 and have tests for that. So it does not seem necessary to test the legacy namedspaces attributes that allowed to override these values. |
…e attribute has no effect., a=testonly Automatic update from web-platform-tests Add MathML reftest to check that the mode attribute has no effect. (#19113) See w3c/mathml#5 -- wpt-commits: e9f2d000237d43f74136cfd40e5a3454f5b54b70 wpt-pr: 19113
…e attribute has no effect., a=testonly Automatic update from web-platform-tests Add MathML reftest to check that the mode attribute has no effect. (#19113) See w3c/mathml#5 -- wpt-commits: e9f2d000237d43f74136cfd40e5a3454f5b54b70 wpt-pr: 19113
See w3c/mathml#5 (comment) and https://groups.google.com/forum/#!topic/mozilla.dev.platform/kl5c87mBlO0 This patch introduces a new preference mathml.deprecated_style_attributes.disabled in order to disable legacy support for attributes background, color, fontfamily, fontsize, fontstyle and fontweight. Note that xlink:href will be handled separately in bug 1575870. * A new counter and deprecation message is introduced for these attributes. In nsMathMLElement, the old WarnDeprecated calls are replaced with a single call to WarnOnceAbout for the deprecate attributes. Notice that for some reason, the color attribute used to send warning in both ParseAttribute and MapMathMLAttributesInto. * sMtableStyles is removed and replaced with a simple comparison. * sMathML3Attributes is split into two tables: one for script attributes which will be handled in bug 1548471 and one for style attributes, handled here. The attributes in this second table is now ignored when the feature flag is disabled. * test_bug553917.html is updated so that it no longer checks the old warning messages for these attributes. New warning messages have been verified manually. * Reftests checking support for these attributes are run with the support enabled. * Finally, WPT tests are run with the support disabled and a new test is added to verify that these attributes are no longer mapped to CSS. Differential Revision: https://phabricator.services.mozilla.com/D43111 UltraBlame original commit: 69105b8565ce19ceb8c26757d0a81138854f1d13
…e attribute has no effect., a=testonly Automatic update from web-platform-tests Add MathML reftest to check that the mode attribute has no effect. (#19113) See w3c/mathml#5 -- wpt-commits: e9f2d000237d43f74136cfd40e5a3454f5b54b70 wpt-pr: 19113 UltraBlame original commit: e2a070880d4f8ad517c375e84ed32b1200e7a6fc
See w3c/mathml#5 (comment) and https://groups.google.com/forum/#!topic/mozilla.dev.platform/kl5c87mBlO0 This patch introduces a new preference mathml.deprecated_style_attributes.disabled in order to disable legacy support for attributes background, color, fontfamily, fontsize, fontstyle and fontweight. Note that xlink:href will be handled separately in bug 1575870. * A new counter and deprecation message is introduced for these attributes. In nsMathMLElement, the old WarnDeprecated calls are replaced with a single call to WarnOnceAbout for the deprecate attributes. Notice that for some reason, the color attribute used to send warning in both ParseAttribute and MapMathMLAttributesInto. * sMtableStyles is removed and replaced with a simple comparison. * sMathML3Attributes is split into two tables: one for script attributes which will be handled in bug 1548471 and one for style attributes, handled here. The attributes in this second table is now ignored when the feature flag is disabled. * test_bug553917.html is updated so that it no longer checks the old warning messages for these attributes. New warning messages have been verified manually. * Reftests checking support for these attributes are run with the support enabled. * Finally, WPT tests are run with the support disabled and a new test is added to verify that these attributes are no longer mapped to CSS. Differential Revision: https://phabricator.services.mozilla.com/D43111 UltraBlame original commit: 69105b8565ce19ceb8c26757d0a81138854f1d13
See w3c/mathml#5 (comment) and https://groups.google.com/forum/#!topic/mozilla.dev.platform/kl5c87mBlO0 This patch introduces a new preference mathml.deprecated_style_attributes.disabled in order to disable legacy support for attributes background, color, fontfamily, fontsize, fontstyle and fontweight. Note that xlink:href will be handled separately in bug 1575870. * A new counter and deprecation message is introduced for these attributes. In nsMathMLElement, the old WarnDeprecated calls are replaced with a single call to WarnOnceAbout for the deprecate attributes. Notice that for some reason, the color attribute used to send warning in both ParseAttribute and MapMathMLAttributesInto. * sMtableStyles is removed and replaced with a simple comparison. * sMathML3Attributes is split into two tables: one for script attributes which will be handled in bug 1548471 and one for style attributes, handled here. The attributes in this second table is now ignored when the feature flag is disabled. * test_bug553917.html is updated so that it no longer checks the old warning messages for these attributes. New warning messages have been verified manually. * Reftests checking support for these attributes are run with the support enabled. * Finally, WPT tests are run with the support disabled and a new test is added to verify that these attributes are no longer mapped to CSS. Differential Revision: https://phabricator.services.mozilla.com/D43111 UltraBlame original commit: 69105b8565ce19ceb8c26757d0a81138854f1d13
…e attribute has no effect., a=testonly Automatic update from web-platform-tests Add MathML reftest to check that the mode attribute has no effect. (#19113) See w3c/mathml#5 -- wpt-commits: e9f2d000237d43f74136cfd40e5a3454f5b54b70 wpt-pr: 19113 UltraBlame original commit: e2a070880d4f8ad517c375e84ed32b1200e7a6fc
…e attribute has no effect., a=testonly Automatic update from web-platform-tests Add MathML reftest to check that the mode attribute has no effect. (#19113) See w3c/mathml#5 -- wpt-commits: e9f2d000237d43f74136cfd40e5a3454f5b54b70 wpt-pr: 19113 UltraBlame original commit: e2a070880d4f8ad517c375e84ed32b1200e7a6fc
https://bugs.webkit.org/show_bug.cgi?id=197492 Patch by Rob Buis <[email protected]> on 2019-09-09 Reviewed by Frédéric Wang. LayoutTests/imported/w3c: Import relevant WPT test. * web-platform-tests/mathml/relations/css-styling/attribute-mapping-001-expected.txt: Added. * web-platform-tests/mathml/relations/css-styling/attribute-mapping-001.html: Added. Source/WebCore: Remove some MathML3 deprecated attributes: w3c/mathml#5 (comment) This change also maps the dir attribute to direction for MathML Core. Test: imported/w3c/web-platform-tests/mathml/relations/css-styling/attribute-mapping-001.html * mathml/MathMLElement.cpp: (WebCore::MathMLElement::collectStyleForPresentationAttribute): LayoutTests: Disable the MathML Core flag for tests assuming MathML3 behavior. * mathml/presentation/attributes-background-color-expected.html: * mathml/presentation/attributes-background-color.html: * mathml/presentation/attributes-mathvariant.html: * mathml/presentation/direction-overall.html: * mathml/presentation/mstyle-css-attributes.html: Canonical link: https://commits.webkit.org/215237@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@249645 268f45cc-cd09-0410-ab3c-d52691b4dbfc
This proposal is to remove the following attributes:
verythinmathspace, thinmathspace, mediummathspace, thickmathspace,
verythickmathspace, veryverythickmathspace. https://mathml-refresh.github.io/mathml/chapter3.html#id.3.3.4.2.1 See also Simplification of the mstyle element #1 and Deprecate/Remove namedspaces length values #75
Math WG thread: https://lists.w3.org/Archives/Public/www-math/2016Aug/0008.html
The text was updated successfully, but these errors were encountered: