[Gecko Bug 1548524] Remove attributes deprecated from MathML3. #18725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See w3c/mathml#5 (comment) and https://groups.google.com/forum/#!topic/mozilla.dev.platform/kl5c87mBlO0 This patch introduces a new preference mathml.deprecated_style_attributes.disabled in order to disable legacy support for attributes background, color, fontfamily, fontsize, fontstyle and fontweight. Note that xlink:href will be handled separately in bug 1575870. * A new counter and deprecation message is introduced for these attributes. In nsMathMLElement, the old WarnDeprecated calls are replaced with a single call to WarnOnceAbout for the deprecate attributes. Notice that for some reason, the color attribute used to send warning in both ParseAttribute and MapMathMLAttributesInto. * sMtableStyles is removed and replaced with a simple comparison. * sMathML3Attributes is split into two tables: one for script attributes which will be handled in bug 1548471 and one for style attributes, handled here. The attributes in this second table is now ignored when the feature flag is disabled. * test_bug553917.html is updated so that it no longer checks the old warning messages for these attributes. New warning messages have been verified manually. * Reftests checking support for these attributes are run with the support enabled. * Finally, WPT tests are run with the support disabled and a new test is added to verify that these attributes are no longer mapped to CSS. Differential Revision: https://phabricator.services.mozilla.com/D43111 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1548524 gecko-commit: 69105b8565ce19ceb8c26757d0a81138854f1d13 gecko-integration-branch: autoland gecko-reviewers: emilio
wpt-pr-bot
approved these changes
Aug 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See w3c/mathml#5 (comment)
and https://groups.google.com/forum/#!topic/mozilla.dev.platform/kl5c87mBlO0
This patch introduces a new preference
mathml.deprecated_style_attributes.disabled in order to disable legacy support
for attributes background, color, fontfamily, fontsize, fontstyle and
fontweight. Note that xlink:href will be handled separately in bug 1575870.
In nsMathMLElement, the old WarnDeprecated calls are replaced with a single
call to WarnOnceAbout for the deprecate attributes. Notice that for some
reason, the color attribute used to send warning in both ParseAttribute and
MapMathMLAttributesInto.
will be handled in bug 1548471 and one for style attributes, handled here.
The attributes in this second table is now ignored when the feature flag is
disabled.
messages for these attributes. New warning messages have been verified
manually.
enabled.
is added to verify that these attributes are no longer mapped to CSS.
Differential Revision: https://phabricator.services.mozilla.com/D43111
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1548524
gecko-commit: 69105b8565ce19ceb8c26757d0a81138854f1d13
gecko-integration-branch: autoland
gecko-reviewers: emilio