Replace PTZ boolean normalization with boolean constraints #271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jan-ivar
requested changes
Jan 15, 2021
There was a problem hiding this comment.
Logic seems sound, but once w3c/mediacapture-main#766 is merged, I'm hoping we can reduce the prose even more. PTAL
|
We should get this PR in before wide review of image capture starts, since it takes advantage of stuff we merged in w3c/mediacapture-main#766. To that end, I'll commit my suggestions above to this PR and solicit reviews. |
jan-ivar
reviewed
Mar 15, 2021
|
TL;DR: We no longer need to normalize away boolean inputs to non-boolean constraints as they're handled in fitness distance: "4. If constraintValue is a boolean, but the constrainable property is not, then the fitness distance is based on whether the settings dictionary's constraintName member exists or not, from the formula |
eehakkin
force-pushed
the
feature/replace-ptz-boolean-normalization-with-boolean-constraints
branch
from
085ac48
to
3bef8ed
Compare
|
Thanks @jan-ivar. As a final touch, I replaced occurrences of |
github-actions bot
added a commit
that referenced
this pull request
Mar 29, 2021
…malization-with-boolean-constraints SHA: 77a4936 Reason: push, by @dontcallmedom Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
eehakkin
deleted the
feature/replace-ptz-boolean-normalization-with-boolean-constraints
branch
blueboxd
pushed a commit
to blueboxd/chromium-legacy
that referenced
this pull request
Apr 14, 2021
This changes pan, tilt and zoom constrainable properties so that for each them there is a single constrainable property which can be constrained either with a boolean constraint (resulting in a fitness distance of 0 or 1) or with a numeric constraint (resulting in a fitness distance from 0.0 to 1.0). Spec: w3c/mediacapture-image#271 w3c/mediacapture-main#766 Change-Id: Iebb0a4f42c518286cefa6b39b2a42f6dbcd30521 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2814545 Commit-Queue: Guido Urdaneta <[email protected]> Auto-Submit: Eero Häkkinen <[email protected]> Reviewed-by: Guido Urdaneta <[email protected]> Cr-Commit-Position: refs/heads/master@{#872352}
mjfroman
pushed a commit
to mjfroman/moz-libwebrtc-third-party
that referenced
this pull request
Oct 14, 2022
This changes pan, tilt and zoom constrainable properties so that for each them there is a single constrainable property which can be constrained either with a boolean constraint (resulting in a fitness distance of 0 or 1) or with a numeric constraint (resulting in a fitness distance from 0.0 to 1.0). Spec: w3c/mediacapture-image#271 w3c/mediacapture-main#766 Change-Id: Iebb0a4f42c518286cefa6b39b2a42f6dbcd30521 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2814545 Commit-Queue: Guido Urdaneta <[email protected]> Auto-Submit: Eero Häkkinen <[email protected]> Reviewed-by: Guido Urdaneta <[email protected]> Cr-Commit-Position: refs/heads/master@{#872352} GitOrigin-RevId: b6a7545796bec4c47a1c2b7504c82932fff7a71d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #256. This along with w3c/mediacapture-main#742 is to clarify meaning of PTZ constraints presence.
Preview | Diff