Source patterns and practices pages from APG #280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for aria-practices ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
howard-e
approved these changes
Dec 11, 2023
There was a problem hiding this comment.
@alflennik thanks for taking this on. This looks good to me! I also spent some time looking through the website with my local build of w3c/wai-website against this branch and found no issues.
I shared a very minor nit below so going ahead with approving!
| @@ -44,6 +50,7 @@ const getLastModifiedDate = async (exampleFilePath) => { | |||
| ); | |||
| throw error; | |||
| } | |||
| // console.log(path.basename(exampleFilePath), dateFormatted) | |||
| @@ -44,6 +43,12 @@ const determineContentType = (sourcePath) => { | |||
| if (sourcePath.endsWith("content/index/index.html")) { | |||
| return "exampleIndex"; | |||
| } | |||
| if ( | |||
There was a problem hiding this comment.
As this file grows, I think we'll want to think about a different mapping structure for the content types just for the benefit of maintenance. I have no actual actionable feedback here, just sharing a very small thought that popped into my head when reviewing all the other statically defined paths here.
mcking65
pushed a commit
to w3c/aria-practices
that referenced
this pull request
Dec 11, 2023
…s.html, and practices.html (pull #2869) Resolve issue 2702 by moving HTML content and images from the wai-aria-practices repo into the aria-practices repo. This includes HTML content for the patterns.html page, the practices.html page, and images across all patterns and examples. A complementary change is made to the build process in the wai-aria-practices repo via PR w3c/wai-aria-practices#280.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sources the patterns and practices pages and all content on them including images, from the aria-practices repo instead of being bolted on later within the wai-aria-practices repo. See w3c/aria-practices#2702 for more information.
Should be merged following the merge of w3c/aria-practices#2869.