For publication / deploy on Tuesday December 12, 2023 #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Source patterns and practices pages from APG
✅ Deploy Preview for aria-practices ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
published/deployed. Thank you for the clear info on the changes in the PR! |
|
Thank you @shawna-slh!! Please survey the production site to ensure image presentation is as expected across patterns, examples, and practices. I will verify the other changes. |
|
I have verified the changes that I can .... I can't test the z index change to modal dialog. @a11ydoer, could you do that please? |
|
@mcking65 Z index looks good. However, there are two same h2, "Read This First" in the dialog modal page. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @shawna-slh. We would like to deploy a new version of the APG as requested by @mcking65 through a recent email thread.
The update includes the following, as sourced from the October 24, 2023 and December 11, 2023 w3c#aria-practices commits:
Landmark Practice: Add note to prevent dialog content wrapped in a landmark (pull #2818)
By mcking65 on Oct 24, 2023
Resolve issue #2512 by adding the following note to principles of landmark design:
View commit eed124a
Infrastructure: Use aria-practices repo as source for images, patterns.html, and practices.html (pull #2869)
By alflennik on Dec 11, 2023
Resolve issue 2702 by moving HTML content and images from the wai-aria-practices repo into the aria-practices repo. This includes HTML content for the patterns.html page, the practices.html page, and images across all patterns and examples. A complementary change is made to the build process in the wai-aria-practices repo via PR w3c/wai-aria-practices#280.
View commit 4bb1946
Infrastructure: Source heading for read this first content from aria-practices repo (pull #2867)
By Paul-Clue on Dec 11, 2023
Moves the h2 element that is part of the "Read This First" content from the wai-aria-practices repo into the aria-practices repo. This is part of an effort to ensure all content is sourced and controlled from the aria-practices repo and the wai-aria-practices repo provides only transformations necessary for site build.
View commit 4a3531f
Modal Dialog Example: Increase z-index of dialog backdrop (pull #2843)
By emamoah on Dec 11, 2023
Resolves issue 2842: A CSS bug where part of the modal dialog popup was obscured on some small screens.
View commit d057791