Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish minutes of 2022-07-21 meeting #245

Merged
merged 1 commit into from
Aug 3, 2022
Merged

Publish minutes of 2022-07-21 meeting #245

merged 1 commit into from
Aug 3, 2022

Conversation

Rob--W
Copy link
Member

@Rob--W Rob--W commented Jul 21, 2022

Generated from https://docs.google.com/document/d/1QkwhEMtMS67JBUkl_WVPZ4lRSKoWcQNlLJSf_GwSXg8/edit using the tool and process from #105.

During this meeting we discussed or mentioned #227, #238, #240, #241, #242, #244, #12, #162, #170, #57, #76, #77, #78, #205, #233.

@Rob--W Rob--W requested review from dotproto and zombie July 21, 2022 16:37
@Rob--W Rob--W removed the request for review from zombie July 21, 2022 20:13
Copy link
Member

@dotproto dotproto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nits aside, LGTM

* [jack] I don't believe we can do this (breaking change).
* [rob] The issue filer is asking to stop firing event listeners in content scripts in response to scripted actions from the web page. This is not a good idea in my opinion; extensions should be prepared to deal with events fired by web pages.
* [rob] [event.isTrusted](https://developer.mozilla.org/en-US/docs/Web/API/Event/isTrusted) can already be used if the extension really cares that the event was triggered by the user.
* [someone] event.isTrusted is only available to events such as click, but not to CustomEvent.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zombie, did you mention this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, someone else did. I don't recall who.

_minutes/2022-07-21-wecg.md Outdated Show resolved Hide resolved
_minutes/2022-07-21-wecg.md Outdated Show resolved Hide resolved
@Rob--W Rob--W merged commit 8b17404 into main Aug 3, 2022
@Rob--W Rob--W deleted the meeting-2022-07-21 branch August 3, 2022 17:05
github-actions bot added a commit that referenced this pull request Aug 3, 2022
SHA: 8b17404
Reason: push, by @Rob--W

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants