Move RTCRtpEncodingParameters.maxFramerate to webrtc-pc #2785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aboba
reviewed
Oct 13, 2022
|
I can preemptively add a link to the tests that are not moved yet from the webrtc-extensions folder to webrtc-pc if that's what you mean. |
Orphis
force-pushed
the
add_maxframerate
branch
from
c708a5e
to
1dad5c7
Compare
|
Also I think you need to modify amendments.json |
|
@Orphis I'll take care of the amendments.json change since that one is a bit complicated |
youennf
reviewed
Oct 13, 2022
youennf
reviewed
Oct 13, 2022
jan-ivar
reviewed
Oct 13, 2022
|
@Orphis will work with @dontcallmedom to fix amendments.json |
It has been implemented in 3 UAs and deserves a promotion.
Orphis
force-pushed
the
add_maxframerate
branch
from
9266293
to
6769e94
Compare
Orphis
commented
Oct 13, 2022
dontcallmedom
added a commit
to dontcallmedom/web-platform-tests
that referenced
this pull request
Nov 15, 2023
This was referenced Nov 15, 2023
Merged
dontcallmedom
added a commit
to web-platform-tests/wpt
that referenced
this pull request
Dec 5, 2023
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Dec 14, 2023
…amerate test into main webrtc…, a=testonly Automatic update from web-platform-tests Integrate RTCRtpEncodingParameters maxFramerate test into main webrtc folder (#43173) per w3c/webrtc-pc#2785 -- wpt-commits: 37e24fab108ec20ee6091f05266875026609f393 wpt-pr: 43173
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Dec 16, 2023
…amerate test into main webrtc…, a=testonly Automatic update from web-platform-tests Integrate RTCRtpEncodingParameters maxFramerate test into main webrtc folder (#43173) per w3c/webrtc-pc#2785 -- wpt-commits: 37e24fab108ec20ee6091f05266875026609f393 wpt-pr: 43173 UltraBlame original commit: 58a38a023451c43f5733f594c24e0976d023ad06
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Dec 16, 2023
…amerate test into main webrtc…, a=testonly Automatic update from web-platform-tests Integrate RTCRtpEncodingParameters maxFramerate test into main webrtc folder (#43173) per w3c/webrtc-pc#2785 -- wpt-commits: 37e24fab108ec20ee6091f05266875026609f393 wpt-pr: 43173 UltraBlame original commit: 58a38a023451c43f5733f594c24e0976d023ad06
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Dec 16, 2023
…amerate test into main webrtc…, a=testonly Automatic update from web-platform-tests Integrate RTCRtpEncodingParameters maxFramerate test into main webrtc folder (#43173) per w3c/webrtc-pc#2785 -- wpt-commits: 37e24fab108ec20ee6091f05266875026609f393 wpt-pr: 43173 UltraBlame original commit: 58a38a023451c43f5733f594c24e0976d023ad06
aosmond
pushed a commit
to aosmond/gecko
that referenced
this pull request
Dec 16, 2023
…amerate test into main webrtc…, a=testonly Automatic update from web-platform-tests Integrate RTCRtpEncodingParameters maxFramerate test into main webrtc folder (#43173) per w3c/webrtc-pc#2785 -- wpt-commits: 37e24fab108ec20ee6091f05266875026609f393 wpt-pr: 43173
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It has been implemented in 3 UAs and deserves a promotion.
Preview | Diff