Improve amendment management #2995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dontcallmedom
force-pushed
the
rec-diff
branch
from
4500403
to
3e168c4
Compare
Using the HTMLDiff code from https://github.com/arai-a/ecma262-compare/blob/gh-pages/js/compare.js#L188
allow to ignore wrapping markup (e.g. addition of a code element inside a link) ignore more ids that aren't meaningful
dontcallmedom
force-pushed
the
rec-diff
branch
from
3e168c4
to
39e91ca
Compare
Vastly simplify by no longer anchoring them in base recommendation
remove syntax highlight when diffing
dontcallmedom
force-pushed
the
rec-diff
branch
from
39e91ca
to
0e5656f
Compare
needed to make markup output valid
dontcallmedom
force-pushed
the
rec-diff
branch
from
4eaca58
to
e4c5fcb
Compare
|
this is now ready to be merged and would benefit from being merged rapidly since it impacts other pull requests documenting amendments (e.g. #2988) cc @jan-ivar @alvestrand |
jan-ivar
approved these changes
Sep 12, 2024
dontcallmedom
added a commit
that referenced
this pull request
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This offers a significantly improved infrastructure to manage the amendments to the WebRTC Recommendation.
In particular:
base-rec.html, and only need to reference the specific section being added) - this follows from discussion with @Orphis in a recent instanceIn addition, this fixes a number of amendments that had not been properly classified.
speced/respec#4786 will be needed to ensure the resulting generated markup is valid.
Preview | Diff