Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve amendment management #2995

Merged
merged 14 commits into from
Sep 12, 2024
Merged

Improve amendment management #2995

merged 14 commits into from
Sep 12, 2024

Commits on Sep 2, 2024

  1. Provide more granular view of diffs 

    Using the HTMLDiff code from https://github.com/arai-a/ecma262-compare/blob/gh-pages/js/compare.js#L188
    @dontcallmedom
    dontcallmedom committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    d97e93a View commit details
    Browse the repository at this point in the history

  2. Customize diff algorithm to match W3C spec needs 

    allow to ignore wrapping markup (e.g. addition of a code element inside a link)
ignore more ids that aren't meaningful
    @dontcallmedom
    dontcallmedom committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    5a910c2 View commit details
    Browse the repository at this point in the history

  3. Add notice on source

    @dontcallmedom
    dontcallmedom committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    4f13cc1 View commit details
    Browse the repository at this point in the history

  4. Align diff with relevant CSS rules

    @dontcallmedom
    dontcallmedom committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    a1cf4e1 View commit details
    Browse the repository at this point in the history

  5. Add postprocessing to keep markup valid

    @dontcallmedom
    dontcallmedom committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    f2cdb35 View commit details
    Browse the repository at this point in the history

  6. Avoid empty element generating bogus markup with diff

    @dontcallmedom
    dontcallmedom committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    640def5 View commit details
    Browse the repository at this point in the history

  7. Document license of imported code

    @dontcallmedom
    dontcallmedom committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    b7e27a4 View commit details
    Browse the repository at this point in the history

  8. Make amendment plugin use respec error reporting facilities

    @dontcallmedom
    dontcallmedom committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    6d3ebfa View commit details
    Browse the repository at this point in the history

  9. Revamp management of 'append' amendments 

    Vastly simplify by no longer anchoring them in base recommendation
    @dontcallmedom
    dontcallmedom committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    7893e6f View commit details
    Browse the repository at this point in the history

  10. Fix detection of missing amendment

    @dontcallmedom
    dontcallmedom committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    94caa1e View commit details
    Browse the repository at this point in the history

  11. Improve diff of IDL fragments 

    remove syntax highlight when diffing
    @dontcallmedom
    dontcallmedom committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    1bd08a4 View commit details
    Browse the repository at this point in the history

  12. Remove unneeded and harmful css for diffed tables

    @dontcallmedom
    dontcallmedom committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    0e5656f View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2024

  1. Fix links to pull requests in amendments wrapper

    @dontcallmedom
    dontcallmedom committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    6813b14 View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2024

  1. Upgrade respec 

    needed to make markup output valid
    @dontcallmedom
    dontcallmedom committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    e4c5fcb View commit details
    Browse the repository at this point in the history