feat(rln-relay): v0.14.0 Release

[rymnc]

Problem

This is to keep track of the rln-relay features to be ready for integration in the next nwaku release 0.14.0.

• bug(rln): Proofs might not be verified under some circumstances  #1270

  • chore(rln-relay): re-enable root validation #1445
  • Tracking Lightpush with rln-relay here: bug(rln-relay): light push does not check proofs before forwarding to relay #1226

• General maintenance (@rymnc)

  • chore(rln-relay): Laundry list for tests #1358
  • chore(rln-relay): refactor mounting procedure #1457

• Static rln lib compilation (@s1fr0 and @LNSD)

  • feat(RLN): load zerokit RLN as static library #1380

• CI feature flagged jobs/checks (@rymnc)

  • feat(ci): run experimental features in diff ci #1410

• RLN Barrel imports (@rymnc)

  • chore(rln-relay): barrel imports #1386

• Add support to Semaphore credentials generation:

  • chore(rln-relay): update key_gen with extended_key_gen logic #1450
  • refactor(rln): use zerokit extended_key_gen in place of key_gen #1459

There are a couple of other low-hanging fruits which we can attempt in case the above list is completed earlier than the deadline.

Acceptance criteria

Getting the listed features ready and tested by the indicated deadline below.
Making sure there is no regression regarding the added features on the waku v2 fleets.

Deadline

January 9, 2023 (one week prior to the next release date)

cc: @jm-clius @oskarth

[staheri14]

Following our call today with @LNSD and @s1fr0 (and another call with @rymnc), below are a non-exhaustive set of refactoring tasks to be tackled (from https://notes.status.im/oozxlJl4QSiEhADbzTEXxA?view):

Tasks that can be attacked independently
The tasks of this section have no specific dependency on other refactoring tasks, so they can be done in parallel or in any desired order.

• Static rln lib compilation (Ind)
  • feat(RLN): load zerokit RLN as static library #1380
• CI feature flagged jobs/checks (Ind)
  • feat(ci): run experimental features in diff ci #1410
• RLN Barrel imports (Ind)
  • chore(rln-relay): barrel imports #1386

Tasks with dependency
The tasks listed here should be tackled in the same order they appear below. This is to minimize the code conflicts and have a speedy development and PR review process.

• 0. Decouple the Waku message type from RLN types. Break a dependency loop. (@rymnc and @LNSD )
  • refactor(rln): decouple rln types from waku message type #1399
• 1. Code split: Split dynamic and static mounting in different modules (@staheri14)
  • Move static mounting constants to the static mounting module (e.g., mimic message store)

  - RLN.nim (barrel import)
  - RLN/
      - STATIC MOUNT.nim (barrel import)
      - STATIC MOUNT/
          - constants.nim
          - logic.nim
      - DYNAMIC MOUNT.nim (barrel import)
      ...
  

• 2. Code split: Split protocol metrics into a module (mimic other protocols) (@rymnc)
• 3. Make the protocol follow the other protocols' mounting pattern (@rymnc)
  • feat(rln-relay): mounting proc waku_node, barrel imports #1379
  • chore(rln-relay): refactor mounting procedure #1457
• 4. Extract group manager interface from waku RLN relay (this one is already captured in the issue description but replicated here to indicate it has a dependency on the above refactoring tasks) (@staheri14 )

As discussed in the call, please tackle each one in a single PR and keep PRs self-contained.

Any comments?

[LNSD]

Any comments?

One little comment 😁

As we discussed, the listed tasks correspond to the first part of the refactoring effort; it is very likely that as these tasks progress and the code changes are reviewed, we will better understand the remaining work, and we'll be in the position to plan and prioritize the second part.

P.S. Thanks for listening to me. We are on the good path and moving forward 👏🏼😁

[staheri14]

it is very likely that as these tasks progress and the code changes are reviewed,

Correct! it is just the first cut, the list may evolve as we progress. cc: @rymnc @s1fr0

[staheri14]

I see there are some updates on the issue description e.g., the deadline. It would be great if after each update we add a comment to this issue and announce it so that the integrated changes get attention.

[LNSD]

Adding the following task/PR to the list:

• Decouple the Waku message type from RLN types. Break a dependency loop.
  • refactor(rln): decouple rln types from waku message type #1399

[rymnc]

@s1fr0 and I have discussed that we are moving the following sections to the next release -

• wallet integration into rln-relay
• robustness of rln-relay
• redeploy rln-contract
  The v0.15.0 issue will include them

[LNSD]

@s1fr0 and I have discussed that we are moving the following sections to the next release -

• wallet integration into rln-relay
• robustness of rln-relay
• redeploy rln-contract
  The v0.15.0 issue will include them

Please, update this issue description accordingly.

We can also file a v0.15.0 issue containing those items (up to you).

[rymnc]

Updated the issue description. I'll create the v0.15.0 issue soon :)

[rymnc]

Created the v0.15.0 issue - #1486

[jm-clius]

@rymnc anything to do here before we close the issue?

[rymnc]

If it looks okay to @s1fr0, we can close it!

[s1fr0]

Thanks @rymnc ! Updated description with some missing elements. Ok for me, I'll close the issue!