refactor(rln): use zerokit extended_key_gen in place of key_gen #1459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refactor(rln): rename membershipKeyPair to identityCredential update zerokit submodule refactor(rln): use extended_key_gen; rebrand keypairs to idCredentials refactor(rln): rename mountRlnRelay memKeyPair argument
s1fr0
added
the
track:rln
1 task
Co-authored-by: Aaryamann Challani <[email protected]>
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #1450 by deprecating in nwaku the zerokit API
key_gento use insteadextended_key_gen.Their difference is:
key_genidentity secret is random and identity commitment is the Poseidon hash of identity secret;-
extended_key_genidentity trapdoor and nullifier are random, identity secret is the poseidon hash of [identity trapdoor, identity nullifier] and identity commitment is the Poseidon hash of identity secret;This will make nwaku RLN identity credentials implementation compliant with 32/RLN-SPEC and credentials will result compatible with Semaphore.
This PR also renames all variables/comments previously referring to keypairs to identity credentials. Data structures are changed accordingly to the new API requirements.
This PR is based on the
rln-relay-mountingbranch which introduces many likely conflicting changes on the RLN module. Will be rebased on master after the latter is merged.