Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(rln-relay): re-enable root validation #1445

Merged
merged 2 commits into from
Dec 5, 2022
Merged

Conversation

rymnc
Copy link
Contributor

@rymnc rymnc commented Dec 5, 2022

Root validation was disabled due to intermittent connections with ethereum nodes, which was preventing nodes from updating their local merkle tree of memberships. Since the underlying issue has been resolved, we can re-enable the check.

  • fix(rln-relay): enable root validation
  • fix(rln-relay): unused import

@rymnc rymnc added the track:rln RLN Track (Secure Messaging/Applied ZK), e.g. relay and applications label Dec 5, 2022
@rymnc rymnc self-assigned this Dec 5, 2022
@rymnc rymnc requested review from LNSD and s1fr0 December 5, 2022 14:27
@rymnc rymnc changed the title chore(rln-relay‚): re-enable root validation chore(rln-relay): re-enable root validation Dec 5, 2022
Copy link
Contributor

@LNSD LNSD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it ready to review?

If so, LGTM ✅

Copy link
Contributor

@s1fr0 s1fr0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rymnc rymnc marked this pull request as ready for review December 5, 2022 18:22
@rymnc rymnc merged commit 2e0db18 into master Dec 5, 2022
@rymnc rymnc deleted the rln-enable-root-validation branch December 5, 2022 18:22
@rymnc rymnc mentioned this pull request Dec 5, 2022
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
track:rln RLN Track (Secure Messaging/Applied ZK), e.g. relay and applications
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants