refactor(node): use store client in waku_node

[LNSD]

The second part of the spit store client PR:

• Remove deprecated methods from store protocol.nim and client.nim
• Move store's peer count metric to waku node
• Waku node store API refactoring and simplification:
  • Now store client logic is decoupled from "server" logic
  • Waku swap is decoupled from waku store client
• Updated wkunode2's --storenode logic to allow using client without mounting store protocol
• Updated tests accordingly

[status-im-auto]

Jenkins Builds

Click to see older builds (12)

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
❌	95f42d8	#1	2022-10-27 22:26:35	~12 min	linux	📄log
❌	95f42d8	#1	2022-10-27 22:32:06	~18 min	macos	📄log
❌	95f42d8	#2	2022-10-27 22:41:11	~12 min	linux	📄log
❌	95f42d8	#2	2022-10-27 22:49:57	~17 min	macos	📄log
❌	fce8662	#3	2022-10-28 08:36:59	~13 min	linux	📄log
❌	fce8662	#3	2022-10-28 08:44:09	~21 min	macos	📄log
✔️	5689852	#4	2022-10-28 12:10:06	~15 min	macos	📦bin
✔️	5689852	#4	2022-10-28 12:10:31	~16 min	linux	📦bin
✔️	42ad25e	#5	2022-10-28 13:57:11	~16 min	linux	📦bin
✔️	42ad25e	#5	2022-10-28 14:02:25	~21 min	macos	📦bin
❌	a928457	#6	2022-10-28 14:07:55	~16 min	linux	📄log
❌	a928457	#6	2022-10-28 14:13:13	~21 min	macos	📄log

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
❌	32dd7d0	#7	2022-10-28 14:49:56	~15 min	macos	📄log
❌	32dd7d0	#7	2022-10-28 14:50:17	~16 min	linux	📄log
❌	32dd7d0	#8	2022-10-28 15:58:01	~15 min	linux	📄log
❌	32dd7d0	#8	2022-10-28 15:58:08	~15 min	macos	📄log
❌	f604c64	#9	2022-10-28 16:29:49	~13 min	linux	📄log
✔️	f604c64	#9	2022-10-28 16:32:10	~15 min	macos	📦bin
✔️	f604c64	#10	2022-10-28 17:50:58	~16 min	linux	📦bin

[jm-clius]

LGTM! We may have to think about peer management, but in principle I like specifying the queried peer directly.

[LNSD]

LGTM! We may have to think about peer management, but in principle I like specifying the queried peer directly.

Absolutely! For now, I am extracting the peer management capabilities outside the different protocol clients (to the waku node) as an intermediate movement. With the goal of simplifying the client code.

[alrevuelta]

lgtm

[LNSD]

Merging with a CI failure. The offending test case has already been reported to the RLN team.