Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: release v0.13.0 #1378

Merged
merged 1 commit into from
Nov 15, 2022
Merged

docs: release v0.13.0 #1378

merged 1 commit into from
Nov 15, 2022

Conversation

jm-clius
Copy link
Contributor

Adds the release notes for Release v0.13.0

I believe everything necessary for the release has been merged already.

For the items you were responsible for, please check:

  • that it's included in the release notes
  • that you're happy with the phrasing

@status-im-auto
Copy link
Collaborator

status-im-auto commented Nov 14, 2022

Jenkins Builds

Click to see older builds (7)
Commit #️⃣ Finished (UTC) Duration Platform Result
⁉️ 421ae08 #1 2022-11-14 14:21:34 ~5 min linux 📄log
⁉️ 421ae08 #1 2022-11-14 14:22:15 ~5 min macos 📄log
⁉️ 304e867 #2 2022-11-14 15:11:42 ~4 min linux 📄log
⁉️ 304e867 #3 2022-11-14 15:12:02 ~5 min linux 📄log
⁉️ 304e867 #2 2022-11-14 15:12:12 ~5 min macos 📄log
⁉️ 3cf5cb5 #4 2022-11-14 15:26:07 ~4 min linux 📄log
⁉️ 3cf5cb5 #3 2022-11-14 15:28:17 ~7 min macos 📄log
Commit #️⃣ Finished (UTC) Duration Platform Result
⁉️ 3a06f43 #5 2022-11-14 15:36:08 ~4 min linux 📄log
⁉️ 3a06f43 #4 2022-11-14 15:37:05 ~5 min macos 📄log
⁉️ 86f2183 #6 2022-11-15 09:18:58 ~4 min linux 📄log
⁉️ 86f2183 #5 2022-11-15 09:20:22 ~6 min macos 📄log

CHANGELOG.md Show resolved Hide resolved
- Cleaned up compiler warnings on unused imports.
- Improved exception handling and annotation.

### Fixes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personal opinion, but I like having the PR as part of the release notes, specially for the fixes. wdyt?
As a reference I like https://github.com/prysmaticlabs/prysm/releases a lot :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, nice reference, thanks. I really like that too - clean and a proper log of everything that was merged. Do you know if they use some kind of auto-generation of release notes from the commit log? I've been considering something like that for nwaku, but am torn between the ease this would provide vs having a curated list of items with impact to user more visible.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like having the PR as part of the release notes

I agree! Since automated release notes are not a thing yet and this is a bit manual, I've just added the PRs now to the fixes. 3cf5cb5

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I usually automatically generate the notes with this. You get all changes + linked PR. And then you just have to make some minor modifications to adapt it. The autogenerated text is quite complete. not sure if we must include every single PR, but it's useful as a reference.

image

What's Changed

New Contributors

Full Changelog: v0.12.0...v0.13.0

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really nice ^!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed! Let's consider for next release. May want to introduce more sections and remove some confusing repeated items, but I like the approach.

CHANGELOG.md Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
Copy link
Contributor

@s1fr0 s1fr0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Suggested few others additional items

Copy link
Contributor

@rymnc rymnc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

CHANGELOG.md Show resolved Hide resolved
Copy link
Contributor

@LNSD LNSD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@alrevuelta alrevuelta self-requested a review November 14, 2022 18:04
Copy link
Contributor

@alrevuelta alrevuelta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Added a minor comment in case autogenerated notes is relevant for next releases.

Copy link
Contributor

@staheri14 staheri14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jm-clius jm-clius merged commit 9debd44 into master Nov 15, 2022
@jm-clius jm-clius deleted the release/v0.13.0 branch November 15, 2022 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants