Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(wakucanary): remove port hardcoding + add cli config #1345

Merged
merged 1 commit into from
Nov 5, 2022
Merged

chore(wakucanary): remove port hardcoding + add cli config #1345

merged 1 commit into from
Nov 5, 2022

Conversation

alrevuelta
Copy link
Contributor

@alrevuelta alrevuelta commented Nov 4, 2022 •
edited
Loading

  • listening port for wakunode was hardcoded to 60000
  • remove hardcoding and add a new cli flag --node-port to configure the port

@status-im-auto
Copy link
Collaborator

status-im-auto commented Nov 4, 2022 •
edited
Loading

Jenkins Builds

❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ f77a7bf #1 2022-11-04 16:13:58 ~18 min linux 📦bin
✔️ f77a7bf #1 2022-11-04 16:16:45 ~21 min macos 📦bin
❌ b4be1d1 #2 2022-11-05 11:35:49 ~15 min linux 📄log
✔️ b4be1d1 #2 2022-11-05 11:39:55 ~19 min macos 📦bin
❌ b4be1d1 #3 2022-11-05 11:52:27 ~1 min linux 📄log

LNSD
LNSD approved these changes Nov 4, 2022
View reviewed changes
Copy link
Contributor

@LNSD LNSD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

jakubgs
jakubgs approved these changes Nov 5, 2022
View reviewed changes
Copy link
Contributor

@jakubgs jakubgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for quick response.

@alrevuelta alrevuelta merged commit c3e665c into master Nov 5, 2022
@alrevuelta alrevuelta deleted the canary-cli-port branch November 5, 2022 11:56
@alrevuelta alrevuelta mentioned this pull request Nov 14, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LNSD LNSD LNSD approved these changes

@jakubgs jakubgs jakubgs approved these changes

@jm-clius jm-clius Awaiting requested review from jm-clius

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alrevuelta @status-im-auto @jakubgs @LNSD