Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize the column names on Events tabs #3376

Closed
7 tasks
LappleApple opened this issue Sep 20, 2023 · 7 comments · Fixed by #3421 or weaveworks/weave-gitops#4055
Closed
7 tasks

Standardize the column names on Events tabs #3376

LappleApple opened this issue Sep 20, 2023 · 7 comments · Fixed by #3421 or weaveworks/weave-gitops#4055
Assignees
Labels
area/ui effort/low team/timber-wolf ui_triage Cross-team/project UI issues for triage

Comments

@LappleApple
Copy link

LappleApple commented Sep 20, 2023

Currently some of our Events tabs use wording that is different from other Events tabs. But there's just one schema for Event objects. To prevent user confusion, let's standardize so that every Events tab includes these four column names:

  • Reason
  • Message
  • From
  • Last Updated

This involves the views:

  • GitOpsSets (Reason, Message, From, Last Updated) -- leave as-is
  • Delivery (Reason, Message, From, Last Updated) -- leave as-is
  • Secrets (Reason, Message, Age--remove this one) -- adjust
  • Terraform (Reason, Message, From, Last Updated) -- leave as-is
  • Applications (Reason, Message, Component, Timestamp) -- adjust
  • Sources (Reason, Message, Component, Timestamp) -- adjust
  • We also wish to apply a tooltip to the "Reason" column name to make its meaning clearer. This tooltip should say: " "Reason" refers to what triggered the event. It can be different according to each component."

Acceptance Criteria:

  • All of the listed views above feature the same column names on their Events tabs.
  • All of the affected views feature the "Reason" tooltip.
  • A tiny "information" icon (thinking an i-in-a-circle) appears next to "Reason."
  • A tiny information icon appears next to From.
  • The user can trigger the tooltips by hovering over the "information" icon.
  • The tooltips appear within one second.

Location of the requested change
Correct names:
Screenshot 2023-09-20 at 10 52 25

Incorrect names:
Screenshot 2023-09-20 at 10 52 14

@LappleApple LappleApple added area/ui ui_triage Cross-team/project UI issues for triage effort/low labels Sep 20, 2023
@TheGostKasper
Copy link
Contributor

@LappleApple , Do we need to Standardize events as well in OSS as it's already the same in Application & Image Automation .
Most of what you mentioned is using the same component so we can easily update all of those pages in one place also that will affect the EE after using that EventTable where it's not used in EE .

@LappleApple
Copy link
Author

@TheGostKasper Yes please (on standardizing in OSS) :)

@LappleApple
Copy link
Author

@TheGostKasper When you say "that will affect the EE after using that EventTable where it's not used in EE," could you elaborate on "affect"--what will be the effect(s)? Thanks much

@TheGostKasper
Copy link
Contributor

TheGostKasper commented Sep 27, 2023

Secrets & Progressive delivery don't use EventTable so i'll make use of it instead of duplicating the component in EE that what i mean.

What will happen actually is that i'll use EventTable in Events' tab so it'll be one component with the same UI results

  • Reason + (tooltip)
  • Message
  • From
  • Last Updated

@LappleApple
Copy link
Author

Got it, thanks much for the info. cc'ing @jpellizzari for awareness about the underneath-the-hood aspects

@TheGostKasper
Copy link
Contributor

redirect3-2023-10-02_13.45.47.mp4

@LappleApple @mmoulian , Do we need any changes to the Reason + icon ?

@LappleApple
Copy link
Author

Hi @TheGostKasper: I'd revise the tooltip text slightly to say: "This refers to what triggered the event, and can vary by component."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ui effort/low team/timber-wolf ui_triage Cross-team/project UI issues for triage
Projects
None yet
2 participants