-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Standardize the column names on Events tabs #3421
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will be reviewed after the OSS PR.
Sorry, commented here instead of the OSS PR, will get to this one now. |
label: 'Reason', | ||
labelRenderer: () => { | ||
return ( | ||
<Reason title="This refers to what triggered the event, and can vary by component."> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the comma before "and" is not needed here because "and" connect two verbs. But English punctuation is not my strong suit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested it locally, LGTM! 🎉
Closes #3376
Currently some of our Events tabs use wording that is different from other Events tabs. But there's just one schema for Event objects. To prevent user confusion, let's standardize so that every Events tab includes these four column names:
This involves the views:
Acceptance Criteria:
redirect3-2023-10-02_13.45.47.mp4