Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize the column names on Events tabs #3421

Merged
merged 5 commits into from
Oct 3, 2023
Merged

Standardize the column names on Events tabs #3421

merged 5 commits into from
Oct 3, 2023

Conversation

TheGostKasper
Copy link
Contributor

@TheGostKasper TheGostKasper commented Oct 2, 2023

Closes #3376
Currently some of our Events tabs use wording that is different from other Events tabs. But there's just one schema for Event objects. To prevent user confusion, let's standardize so that every Events tab includes these four column names:

  • Reason
  • Message
  • From
  • Last Updated

This involves the views:

  • GitOpsSets (Reason, Message, From, Last Updated) -- leave as-is
  • Delivery (Reason, Message, From, Last Updated) -- leave as-is
  • Secrets (Reason, Message, Age--remove this one) -- adjust
  • Terraform (Reason, Message, From, Last Updated) -- leave as-is
  • Applications (Reason, Message, Component, Timestamp) -- adjust
  • Sources (Reason, Message, Component, Timestamp) -- adjust
  • We also wish to apply a tooltip to the "Reason" column name to make its meaning clearer. This tooltip should say: " "Reason" refers to what triggered the event. It can be different according to each component."

Acceptance Criteria:

  • All of the listed views above feature the same column names on their Events tabs.
  • All of the affected views feature the "Reason" tooltip.
  • A tiny "information" icon (thinking an i-in-a-circle) appears next to "Reason."
  • A tiny information icon appears next to From.
  • The user can trigger the tooltips by hovering over the "information" icon.
  • The tooltips appear within one second.
redirect3-2023-10-02_13.45.47.mp4

Copy link
Contributor

@opudrovs opudrovs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will be reviewed after the OSS PR.

@opudrovs opudrovs self-requested a review October 2, 2023 14:10
@opudrovs
Copy link
Contributor

opudrovs commented Oct 2, 2023

Sorry, commented here instead of the OSS PR, will get to this one now.

label: 'Reason',
labelRenderer: () => {
return (
<Reason title="This refers to what triggered the event, and can vary by component.">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the comma before "and" is not needed here because "and" connect two verbs. But English punctuation is not my strong suit.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@opudrovs opudrovs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it locally, LGTM! 🎉

@TheGostKasper TheGostKasper merged commit de0e903 into main Oct 3, 2023
10 checks passed
@TheGostKasper TheGostKasper deleted the ee-3376 branch October 3, 2023 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ui enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Standardize the column names on Events tabs
3 participants