Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Standardize the column names on Events tabs #4055

Merged
merged 2 commits into from
Oct 2, 2023
Merged

Standardize the column names on Events tabs #4055

merged 2 commits into from
Oct 2, 2023

Conversation

TheGostKasper
Copy link
Contributor

@TheGostKasper TheGostKasper commented Oct 2, 2023 •
edited
Loading

Closes EE-3376

Currently some of our Events tabs use wording that is different from other Events tabs. But there's just one schema for Event objects. To prevent user confusion, let's standardize so that every Events tab includes these four column names:

  • Reason
  • Message
  • From
  • Last Updated

This change will affect :

  • Applications (Reason, Message, Component, Timestamp) -- adjust
  • Sources (Reason, Message, Component, Timestamp) -- adjust
  • We also wish to apply a tooltip to the "Reason" column name to make its meaning clearer. This tooltip should say: " "Reason" refers to what triggered the event. It can be different according to each component."

@TheGostKasper TheGostKasper added the area/ui Issues that require front-end work label Oct 2, 2023
opudrovs
opudrovs approved these changes Oct 2, 2023
View reviewed changes
Copy link
Contributor

@opudrovs opudrovs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@TheGostKasper TheGostKasper merged commit b5f38d0 into main Oct 2, 2023
22 checks passed
@TheGostKasper TheGostKasper deleted the ee-3376 branch October 2, 2023 14:24
@weave-gitops-bot weave-gitops-bot mentioned this pull request Oct 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@opudrovs opudrovs opudrovs approved these changes

@joshri joshri Awaiting requested review from joshri

Assignees
No one assigned
Labels
area/ui Issues that require front-end work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Standardize the column names on Events tabs
2 participants
@TheGostKasper @opudrovs