Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot bootstrap non-interactive with ssh and empty password key #3737

Closed
Tracked by #3026
enekofb opened this issue Dec 19, 2023 · 1 comment · Fixed by #3738
Closed
Tracked by #3026

Cannot bootstrap non-interactive with ssh and empty password key #3737

enekofb opened this issue Dec 19, 2023 · 1 comment · Fixed by #3738
Assignees
Labels
area/cli issues related to gitops ee cli bug Something isn't working team/tangerine

Comments

@enekofb
Copy link
Contributor

enekofb commented Dec 19, 2023

Cannot bootstrap non-interactive with ssh and empty password key

Current Behaviour

➜  weave-gitops-enterprise git:(3496-handle-wge-bootstrapped) ✗ go run cmd/gitops/main.go bootstrap --bootstrap-flux --components-extra=none --private-key=/Users/enekofb/.ssh/weaveworks/dev  --private-key-password="" --version="0.37.0" --git-username="$GITHUB_USER" --git-password="$GITHUB_TOKEN" \\n     --repo-url=https://github.com/enekofb/cli-dev.git --branch="main"  --repo-path=clusters/management

► creating client to cluster
✔ created client to cluster: https://127.0.0.1:62313/
► verifying flux installation
✔ flux is installed
► verifying flux reconciliation
✔ flux is bootstrapped
✔ detected git scheme: ssh
► Weave GitOps Enterprise is already installed in namespace flux-system
◎ bootstrap flux
◎ flux repository configuration
◎ git credentials
✔ private key password: █

Expected Behaviour

  • Private key password used from flags

More info:

https://weaveworks.slack.com/archives/C05HC9R4DUG/p1702890948159969?thread_ts=1702463630.917539&cid=C05HC9R4DUG #3737

@enekofb enekofb added bug Something isn't working area/cli issues related to gitops ee cli labels Dec 19, 2023
@enekofb enekofb changed the title bug cannot bootstrap non-interactive with ssh and empty password key https://weaveworks.slack.com/archives/C05HC9R4DUG/p1702890948159969?thread_ts=1702463630.917539&cid=C05HC9R4DUG Cannot bootstrap non-interactive with ssh and empty password key Dec 19, 2023
@enekofb enekofb self-assigned this Dec 19, 2023
@enekofb
Copy link
Contributor Author

enekofb commented Dec 19, 2023

the reason is that we dont have a clear distinction between the scenario where the user has not introduce value or empty as the string zero value is empty

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cli issues related to gitops ee cli bug Something isn't working team/tangerine
Projects
None yet
1 participant