bootstrapping does not ask for ssh password key if empty is introduced by the user

[enekofb]

Closes #3737

What changed?

• Supports use case for flags with default valid value empty string via using flags.changed cobra func

Why was this change made?

• Cause we were not able during configuration whether the empty string was default or coming from user.

How was this change implemented?

intially tested that the expected behaviour

func TestBootstrapCmdConfig(t *testing.T) {

	tests := []struct {
		name        string
		flags       []string
		wantErr     assert.ErrorAssertionFunc
		wantChanged bool
	}{
		{
			name: "should detect user introduced value for private-key-password",
			flags: []string{
				"--private-key-password=\"\"",
			},
			wantErr:     assert.NoError,
			wantChanged: true,
		},
		{
			name:        "should detect user introduced value for private-key-password",
			flags:       []string{},
			wantErr:     assert.NoError,
			wantChanged: false,
		},
	}
	for _, tt := range tests {
		t.Run(tt.name, func(t *testing.T) {
			var options = &config.Options{}
			cmd := Command(options)

			err := cmd.ParseFlags(tt.flags)

			if tt.wantErr != nil {
				tt.wantErr(t, err, "unexpected error ")
				return
			}
			assert.Equal(t, tt.wantChanged, cmd.Flags().Changed("private-key-password"), "invalid value for private-key-password")
		})
	}
}

How did you validate the change?

• Explain how a reviewer can verify the change themselves

run the command and will see that no longer is asking when introduced empty

➜  weave-gitops-enterprise git:(wge-3737-support-empty-ssh-password-key) ✗ go run cmd/gitops/main.go bootstrap --bootstrap-flux --components-extra=none --private-key=/Users/enekofb/.ssh/weaveworks/dev  --private-key-password="" --version="0.37.0" --git-username="$GITHUB_USER" --git-password="$GITHUB_TOKEN" \\n     --repo-url=https://github.com/enekofb/cli-dev.git --branch="main"  --repo-path=clusters/management
► creating client to cluster
✔ created client to cluster: https://127.0.0.1:62313
► verifying flux installation
✔ flux is installed
► verifying flux reconciliation
✔ flux is bootstrapped
✔ detected git scheme: ssh
► Weave GitOps Enterprise is already installed in namespace flux-system
◎ bootstrap flux
◎ flux repository configuration
◎ git credentials
◎ checking entitlement

asking when no introduced

➜  weave-gitops-enterprise git:(wge-3737-support-empty-ssh-password-key) ✗ go run cmd/gitops/main.go bootstrap --bootstrap-flux --components-extra=none --private-key=/Users/enekofb/.ssh/weaveworks/dev  --version="0.37.0" --git-username="$GITHUB_USER" --git-password="$GITHUB_TOKEN" \\n     --repo-url=https://github.com/enekofb/cli-dev.git --branch="main"  --repo-path=clusters/management
► creating client to cluster
✔ created client to cluster: https://127.0.0.1:62313
► verifying flux installation
✔ flux is installed
► verifying flux reconciliation
✔ flux is bootstrapped
✔ detected git scheme: ssh
► Weave GitOps Enterprise is already installed in namespace flux-system
◎ bootstrap flux
◎ flux repository configuration
◎ git credentials
✔ private key password: █

• Integration tests -- what is covered, what cannot be covered;
  or, explain why there are no new tests
• Unit tests -- what is covered, what cannot be covered; are
  there tests that fail without the change?

Release notes

Documentation Changes

Updated internal style guide

Other follow ups

No

[Samra10]

LGTM.
Tested and working as expected ✅