Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

documentation added for pipelines #2793

Merged
merged 22 commits into from
Oct 4, 2022
Merged

documentation added for pipelines #2793

merged 22 commits into from
Oct 4, 2022

Conversation

enekofb
Copy link
Contributor

@enekofb enekofb commented Sep 27, 2022

Closes weaveworks/weave-gitops-enterprise#1274

What changed?
Added documentation for pipelines

Why was this change made?

In order to document the released feature

How was this change implemented?

Adding documentation. It is place under the enterprise section, differently to other enterprise features in the main documentation root. the motivation is that seems to be a more clear navigation for users.

How did you validate the change?

Locally
Screenshot 2022-10-03 at 11 07 57

Release notes

  • No

Documentation Changes

  • It is a documentation change itself

@enekofb enekofb added the documentation Improvements or additions to documentation label Sep 27, 2022
@enekofb enekofb marked this pull request as ready for review October 3, 2022 10:04
@enekofb enekofb changed the title scaffolding for pipelines documentation added for pipelines Oct 3, 2022
Copy link
Contributor

@yiannistri yiannistri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍 I'm not sure we need to show details of the Go types of the pipeline and keep that reference always current going forward if we don't provide a way to interact with it programmatically. But I can be convinced otherwise.

website/docs/enterprise/pipelines/getting-started.mdx Outdated Show resolved Hide resolved
website/docs/enterprise/pipelines/getting-started.mdx Outdated Show resolved Hide resolved
namespace: flux-system
```

In the previous example, `podinfo` application is delivered to a traditional pipeline composed by `dev`, `qa`, (`perf`) and `production` environments.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why perf needs to be wrapped in round brackets.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove the wrapping

website/docs/enterprise/pipelines/getting-started.mdx Outdated Show resolved Hide resolved
website/docs/enterprise/pipelines/getting-started.mdx Outdated Show resolved Hide resolved
website/docs/enterprise/pipelines/intro.mdx Outdated Show resolved Hide resolved
website/docs/enterprise/pipelines/intro.mdx Outdated Show resolved Hide resolved
website/docs/enterprise/pipelines/getting-started.mdx Outdated Show resolved Hide resolved
website/docs/enterprise/pipelines/getting-started.mdx Outdated Show resolved Hide resolved
@enekofb
Copy link
Contributor Author

enekofb commented Oct 4, 2022

Looks good to me 👍 I'm not sure we need to show details of the Go types of the pipeline and keep that reference always current going forward if we don't provide a way to interact with it programmatically. But I can be convinced otherwise.

@yiannistri

do you mean?

https://github.com/weaveworks/weave-gitops/pull/2793/files#diff-e5b3bdfc3a2cfcc6447284d76b58139d8df76bb32b72786e018f8e82cb9ef3fcR56

it just mimics flux documentation https://github.com/fluxcd/helm-controller/blob/main/docs/spec/v2beta1/helmreleases.md

mentioned in the standup, not sure whether this is the approach that we want to follow so feel free to share preference / alternative

@sympatheticmoose
Copy link
Contributor

Thank you @enekofb for taking the time to write these docs. They're good - my comments are mostly nits.

On reflection, I am wondering about the nesting under enterprise and some placement of the docs. However, we are about to revisit the overall structure and more changes may occur. In terms of expedience, please feel free to merge in their current form, and we can use some of the comments I've made in this PR when reworking the site structure.

@yiannistri
Copy link
Contributor

do you mean?

https://github.com/weaveworks/weave-gitops/pull/2793/files#diff-e5b3bdfc3a2cfcc6447284d76b58139d8df76bb32b72786e018f8e82cb9ef3fcR56

it just mimics flux documentation https://github.com/fluxcd/helm-controller/blob/main/docs/spec/v2beta1/helmreleases.md

mentioned in the standup, not sure whether this is the approach that we want to follow so feel free to share preference / alternative

Yes I was referring to those. I think they're useful in general but I would suggest postpone adding them because a) we're still making changes to the CRD for promotions and b) the current spec is not as sophisticated as the Flux primitives to justify adding them to docs.

Other than that, the docs look good so I'll defer to your judgement regarding this.

@enekofb
Copy link
Contributor Author

enekofb commented Oct 4, 2022

do you mean?
https://github.com/weaveworks/weave-gitops/pull/2793/files#diff-e5b3bdfc3a2cfcc6447284d76b58139d8df76bb32b72786e018f8e82cb9ef3fcR56
it just mimics flux documentation https://github.com/fluxcd/helm-controller/blob/main/docs/spec/v2beta1/helmreleases.md
mentioned in the standup, not sure whether this is the approach that we want to follow so feel free to share preference / alternative

Yes I was referring to those. I think they're useful in general but I would suggest postpone adding them because a) we're still making changes to the CRD for promotions and b) the current spec is not as sophisticated as the Flux primitives to justify adding them to docs.

Other than that, the docs look good so I'll defer to your judgement regarding this.

@yiannistri sounds good, i could remove it however there is gap that I could think we need to cover which is

as user without pipelines knowledge, i want to have some documentation to write a pipeline

for example to understand the different namespaces or so

https://github.com/weaveworks/weave-gitops/pull/2793/files#diff-e5b3bdfc3a2cfcc6447284d76b58139d8df76bb32b72786e018f8e82cb9ef3fcR90-R93

this is part of the CRD / generated go types.

How should we capture this?

@yiannistri
Copy link
Contributor

Fair enough 👍 Let's get this in.

@enekofb enekofb merged commit 7bb985e into main Oct 4, 2022
@enekofb enekofb deleted the add-pipelines-docs branch October 4, 2022 14:32
foot pushed a commit that referenced this pull request Oct 14, 2022
* scaffolding for pipelines

* added rbac for view pipelines

* just an intro added

* adding getting started for pipelines

* changed to podinfo02

* added pipeline spec as flux docs

* pipelines moved into enterprise

* reviewed links

* reviewed rbac

* fixed broken link

* Update website/docs/enterprise/pipelines/getting-started.mdx

Co-authored-by: Yiannis <[email protected]>

* Update website/docs/enterprise/pipelines/getting-started.mdx

Co-authored-by: Yiannis <[email protected]>

* Update website/docs/enterprise/pipelines/getting-started.mdx

Co-authored-by: Yiannis <[email protected]>

* Update website/docs/enterprise/pipelines/intro.mdx

Co-authored-by: Yiannis <[email protected]>

* Update website/docs/enterprise/pipelines/getting-started.mdx

Co-authored-by: Yiannis <[email protected]>

* Update website/docs/enterprise/pipelines/getting-started.mdx

Co-authored-by: Yiannis <[email protected]>

* Update website/docs/enterprise/pipelines/getting-started.mdx

Co-authored-by: Yiannis <[email protected]>

* Update website/docs/enterprise/pipelines/spec/v1alpha1/pipeline.mdx

Co-authored-by: Yiannis <[email protected]>

* Update website/docs/enterprise/pipelines/intro.mdx

Co-authored-by: Yiannis <[email protected]>

* removed not wrapped

Co-authored-by: Yiannis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add documentation for pipelines
3 participants