[UI] Add edit option to resources that have create template in annotation #2846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshri
approved these changes
Oct 11, 2022
|
Cheers Josh, fair points :)! I've moved the Edit Button to EE and added types for actions (we can extend at a later date if necessary) |
foot
pushed a commit
that referenced
this pull request
Oct 14, 2022
…tion (#2846) * Add edit option to resources that have create template in anno - WIP * Move edit option to resource details page * Refactor edit in details * Extract custom actions component * Remove edit from core details table * Remove edit from core details table - updated * Fix some errors * Add custom actions to the details page * Add custom actions to the details page - updated * Add actions type and move edit button * Add actions type and move edit button - updated * Lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of https://app.zenhub.com/workspaces/team-pesto-6127680175876a0014fc5657/issues/weaveworks/weave-gitops-enterprise/1591
Added the
CustomActionsComponent in order to addEditto the standardSyncandSuspendon the Resource Details page in EE.The Edit is solely used by resources created by the user via templates so it will only be visible in EE.