Skip to content
This repository has been archived by the owner on Jun 20, 2024. It is now read-only.

Proxy should not swallow any messages that weave sends to stderr #1056

Closed
bboreham opened this issue Jul 1, 2015 · 1 comment
Closed

Proxy should not swallow any messages that weave sends to stderr #1056

bboreham opened this issue Jul 1, 2015 · 1 comment
Assignees
@paulbellamy
Labels
chore [component/proxy]
Milestone
1.1.0

Comments

@bboreham
Copy link
Contributor

bboreham commented Jul 1, 2015

The weave script may emit warnings or errors as it goes about its business, e.g. attaching a new container to the weave network. Currently it seems these messages are swallowed.

At minimum they should go in the weaveproxy log.

Injecting them as output to be presented by the docker cli might be attractive, but potentially dangerous for users that are expecting very specific output from their containers.

Where should they go for clients that call via the Docker remote API?
@rade
Copy link
Member

rade commented Jul 1, 2015

Injecting them as output to be presented by the docker cli might be attractive, but potentially dangerous for users that are expecting very specific output from their containers.

Agreed; let's just put them in the logs.

@bboreham bboreham mentioned this issue Jul 1, 2015
Merged
@rade rade modified the milestone: current Jul 2, 2015
@paulbellamy paulbellamy self-assigned this Jul 3, 2015
@paulbellamy paulbellamy mentioned this issue Jul 3, 2015
Merged
@rade rade closed this as completed in #1067 Jul 4, 2015
rade added a commit that referenced this issue Jul 4, 2015
@rade
Merge pull request #1067 from paulbellamy/proxy-stderr
b30de63 
print all stderr output from callWeave to the proxy logs, even if successful

Closes #1056
@rade rade modified the milestones: current, 1.1.0 Jul 13, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@paulbellamy paulbellamy

Labels
chore [component/proxy]
Projects
None yet
Milestone
1.1.0
Development

No branches or pull requests
3 participants
@rade @paulbellamy @bboreham