[proxy] print all stderr output from callWeave to the proxy logs, even if successful #1067

paulbellamy · 2015-07-03T12:21:20Z

rade · 2015-07-03T12:34:19Z

We don't want to log what comes out of stdout. We want to log a warning when anything comes out of stderr.

…ccessful

proxy/proxy.go

 		if err != nil {
-			return nil, err
+			return nil, fmt.Errorf(string(stderr))


rade · 2015-07-03T15:32:12Z

It would be good to (manually) test this with the warning spat out by #1053, since that is what prompted filing of the issue.

rade · 2015-07-04T02:44:29Z

It would be good to (manually) test this with the warning spat out by #1053, since that is what prompted filing of the issue.

Have done this. All ok.

In future please create PR branches on weaveworks/weave.

print all stderr output from callWeave to the proxy logs, even if successful Closes #1056

rade assigned paulbellamy Jul 3, 2015

bboreham changed the title ~~[proxy] print all output from callWeave to the proxy logs, even if successful~~ [proxy] print all stderr output from callWeave to the proxy logs, even if successful Jul 3, 2015

[proxy] print all stderr from callWeave to the proxy logs, even if su…

7821412

…ccessful

paulbellamy force-pushed the proxy-stderr branch from 6269fe1 to 7821412 Compare July 3, 2015 14:45

paulbellamy assigned rade and unassigned paulbellamy Jul 3, 2015

rade reviewed Jul 3, 2015
View reviewed changes

proxy/proxy.go

if err != nil {

return nil, err

return nil, fmt.Errorf(string(stderr))

This comment was marked as abuse.

Sign in to view

This comment was marked as abuse.

Sign in to view

rade assigned paulbellamy and rade and unassigned rade and paulbellamy Jul 3, 2015

rade assigned paulbellamy and unassigned rade Jul 3, 2015

rade added a commit that referenced this pull request Jul 4, 2015

Merge pull request #1067 from paulbellamy/proxy-stderr

b30de63

print all stderr output from callWeave to the proxy logs, even if successful Closes #1056

rade merged commit b30de63 into weaveworks:master Jul 4, 2015

rade deleted the proxy-stderr branch July 4, 2015 02:44

rade added this to the current milestone Jul 4, 2015

rade modified the milestones: current, 1.1.0 Jul 13, 2015

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[proxy] print all stderr output from callWeave to the proxy logs, even if successful #1067

[proxy] print all stderr output from callWeave to the proxy logs, even if successful #1067

paulbellamy commented Jul 3, 2015

rade commented Jul 3, 2015

This comment was marked as abuse.

This comment was marked as abuse.

rade commented Jul 3, 2015

rade commented Jul 4, 2015

[proxy] print all stderr output from callWeave to the proxy logs, even if successful #1067

[proxy] print all stderr output from callWeave to the proxy logs, even if successful #1067

Conversation

paulbellamy commented Jul 3, 2015

rade commented Jul 3, 2015

This comment was marked as abuse.

This comment was marked as abuse.

rade commented Jul 3, 2015

rade commented Jul 4, 2015