Skip to content
This repository has been archived by the owner on Jun 20, 2024. It is now read-only.

with --rewrite-inspect proxy modifies how integers are marshalled #1390

Closed
errordeveloper opened this issue Sep 4, 2015 · 1 comment
Closed

with --rewrite-inspect proxy modifies how integers are marshalled #1390

errordeveloper opened this issue Sep 4, 2015 · 1 comment
Assignees
@bboreham
Labels
bug
Milestone
1.1.0

Comments

@errordeveloper
Copy link
Contributor

From testing latest change (32a82f2) on Kubernetes, one rather critical issue popped-up. Essentially what happens is that we somehow end-up marshalling integers in scientific notation and the parser on the other end fail with json: cannot unmarshal number 5.24288e+07 into Go value of type int64.
@errordeveloper errordeveloper mentioned this issue Sep 4, 2015
Closed
@rade rade added this to the current milestone Sep 4, 2015
@rade
Copy link
Member

rade commented Sep 4, 2015

looks like we need UseNumber().

@bboreham bboreham assigned bboreham and unassigned paulbellamy Sep 4, 2015
@bboreham bboreham mentioned this issue Sep 4, 2015
Merged
@rade rade closed this as completed in #1391 Sep 4, 2015
rade added a commit that referenced this issue Sep 4, 2015
@rade
Merge pull request #1391 from weaveworks/1390-use-number
f782fb5 
Stop marshalling numbers as floats

Fixes #1390.
@rade rade modified the milestones: 1.1.0, current Sep 4, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bboreham bboreham

Labels
bug
Projects
None yet
Milestone
1.1.0
Development

No branches or pull requests
4 participants
@rade @paulbellamy @errordeveloper @bboreham