Skip to content
This repository has been archived by the owner on Jun 20, 2024. It is now read-only.

Stop marshalling numbers as floats #1391

Merged
merged 1 commit into from
Sep 4, 2015
Merged

Stop marshalling numbers as floats #1391

merged 1 commit into from
Sep 4, 2015

Conversation

bboreham
Copy link
Contributor

@bboreham bboreham commented Sep 4, 2015

Fixes #1390

Note that setting both --memory and --memory-swap is done to avoid Docker issuing a warning that it can't set the swap limit.

@rade
Copy link
Member

rade commented Sep 4, 2015

I don't think the test is worth the hassle. remove.

@bboreham
Copy link
Contributor Author

bboreham commented Sep 4, 2015

Are you referring to the last grep? Since it works on my machine and fails on CircleCI, I can easily agree with that sentiment.

However, just setting the memory limit (so there is a large number in the output) breaks docker inspect -f (without the UseNumber fix), so I think that is worth keeping.

@rade
Copy link
Member

rade commented Sep 4, 2015

I am saying we don't need a test for this issue at all. Heresy, I know.

@bboreham
Copy link
Contributor Author

bboreham commented Sep 4, 2015

You are saying to remove the whole file 605_proxy_inspect_test.sh ?

I guess I can put the memory limit into test 610. I like the idea of having a test that would have caught this error.

@rade
Copy link
Member

rade commented Sep 4, 2015

no, I am saying don't add any extra test for this issue. i.e. 605_proxy_inspect_test.sh should remain unchanged.

@bboreham
Copy link
Contributor Author

bboreham commented Sep 4, 2015

Done.

rade added a commit that referenced this pull request Sep 4, 2015
Stop marshalling numbers as floats

Fixes #1390.
@rade rade merged commit f782fb5 into master Sep 4, 2015
@rade rade added this to the 1.1.0 milestone Sep 4, 2015
@rade rade deleted the 1390-use-number branch October 1, 2015 15:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants