Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run affected tests in Edge and Safari for PRs #13299

Closed
foolip opened this issue Oct 1, 2018 · 9 comments
Closed

Run affected tests in Edge and Safari for PRs #13299

foolip opened this issue Oct 1, 2018 · 9 comments

Comments

@foolip
Copy link
Member

foolip commented Oct 1, 2018

One upon a time we had Chrome, Edge, Firefox and Safari all running some tests for PRs. It was never robust enough to be truly useful, but we had it until we had to remove Edge and Safari in #9903.

We are now in the process (#13194) of moving Chrome and Firefox to Taskcluster and we'll use the results in #7475.

That still leaves Edge and Safari without any coverage on PRs.

For Edge, there doesn't appear to exist an CI integrated with GitHub where we could run Edge, much less Edge Insider Preview. @thejohnjansen for ideas.

For Safari, it's possible we could use Travis's macOS support, but nobody has tested this. It would also be a fairly different setup from what @jugglinmike has set up. @youennf for ideas.

The value of this would be preventing accidental regressions of tests in Edge and Safari, just like for Chrome and Firefox.

@foolip
Copy link
Member Author

foolip commented Oct 1, 2018

travis-ci/travis-ci#7187 as some discussion on Safari in Travis.

@foolip
Copy link
Member Author

foolip commented Oct 1, 2018

In foolip#3 I've experimented with macOS on Travis to the point where I got Safari TP installed, do nothing with it, and then run a lint that fails:
https://travis-ci.org/foolip/web-platform-tests/builds/435885997

(For Safari 12 stable, the Travis macOS image wasn't new enough, "This update requires macOS version 10.13.6 or later", but Travis's latest is 10.13.3.)

Put together with some of @jugglinmike's amazing tricks for macOS in https://github.com/web-platform-tests/results-collection it would probably be possible to run affected tests on Safari TP on Travis.

Whether we run them 10 times for stability or just once for results, this will time out if too many tests are affected. We'd also have to find a way to get the results into wpt.fyi. So it's not a trivial undertaking, but at least the OS images exist and probably work for this.

@foolip
Copy link
Member Author

foolip commented Oct 2, 2018

I've also experimented briefly with Cirrus CI. Their macOS support is ultimately backed by https://www.macstadium.com/, which I recall @jugglinmike has mentioned at some point.

Cirrus CI has macOS 10.13.5, and in foolip#4 I got it as far as with Travis, namely I got STP 65 installed.

There's also https://circleci.com/build-environments/xcode/osx/ but I haven't tried it.

Overall, for macOS, it appears that the infrastructure exists that would allow us to get this off the ground.

@foolip
Copy link
Member Author

foolip commented Oct 2, 2018

Also worth noticing is that https://cirrus-ci.org/guide/macOS/ points to https://github.com/cirruslabs/osx-images and that perhaps custom images are possible. It's probably not necessary though, installing STP didn't take long.

foolip added a commit that referenced this issue Oct 30, 2018
This just runs infrastructure/ tests on relevant PRs, something minimal
and useful before trying to enable Azure Pipelines for the first time.

Part of #13299.
foolip added a commit that referenced this issue Oct 31, 2018
This just runs infrastructure/ tests on relevant PRs, something minimal
and useful before trying to enable Azure Pipelines for the first time.

Part of #13299.

Next step: #13818
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this issue Nov 10, 2018
…=testonly

Automatic update from web-platform-testsAdd configuration for Azure Pipelines (#13769)

This just runs infrastructure/ tests on relevant PRs, something minimal
and useful before trying to enable Azure Pipelines for the first time.

Part of web-platform-tests/wpt#13299.

Next step: web-platform-tests/wpt#13818
--

wpt-commits: 4098fe5f1f08442a8d63db9eb107b49a2f4fe752
wpt-pr: 13769
jyc pushed a commit to jyc/gecko that referenced this issue Nov 11, 2018
…=testonly

Automatic update from web-platform-testsAdd configuration for Azure Pipelines (#13769)

This just runs infrastructure/ tests on relevant PRs, something minimal
and useful before trying to enable Azure Pipelines for the first time.

Part of web-platform-tests/wpt#13299.

Next step: web-platform-tests/wpt#13818
--

wpt-commits: 4098fe5f1f08442a8d63db9eb107b49a2f4fe752
wpt-pr: 13769
@chauser123
Copy link

Whatvdo you suggest i do? Should we try removing safari?

@foolip
Copy link
Member Author

foolip commented Dec 2, 2018

@chauser123 no action is required on your part unless you want to work on the Azure Pipelines setup.

@foolip
Copy link
Member Author

foolip commented Dec 3, 2018

Edge: explored in #14300

Safari: #14156

@foolip
Copy link
Member Author

foolip commented Jan 30, 2019

This is done for Safari, but I'm going to close this without doing it for Edge given that it will no longer be actively developed, and so making changes to PRs on the basis of results from Edge doesn't seem like a good use of time. In #15174 I will still try to get full daily runs, however.

@foolip foolip closed this as completed Jan 30, 2019
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this issue Oct 3, 2019
…=testonly

Automatic update from web-platform-testsAdd configuration for Azure Pipelines (#13769)

This just runs infrastructure/ tests on relevant PRs, something minimal
and useful before trying to enable Azure Pipelines for the first time.

Part of web-platform-tests/wpt#13299.

Next step: web-platform-tests/wpt#13818
--

wpt-commits: 4098fe5f1f08442a8d63db9eb107b49a2f4fe752
wpt-pr: 13769

UltraBlame original commit: afe5654fe9baae07072ff2384738e54bd29c1601
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this issue Oct 3, 2019
…=testonly

Automatic update from web-platform-testsAdd configuration for Azure Pipelines (#13769)

This just runs infrastructure/ tests on relevant PRs, something minimal
and useful before trying to enable Azure Pipelines for the first time.

Part of web-platform-tests/wpt#13299.

Next step: web-platform-tests/wpt#13818
--

wpt-commits: 4098fe5f1f08442a8d63db9eb107b49a2f4fe752
wpt-pr: 13769

UltraBlame original commit: afe5654fe9baae07072ff2384738e54bd29c1601
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this issue Oct 3, 2019
…=testonly

Automatic update from web-platform-testsAdd configuration for Azure Pipelines (#13769)

This just runs infrastructure/ tests on relevant PRs, something minimal
and useful before trying to enable Azure Pipelines for the first time.

Part of web-platform-tests/wpt#13299.

Next step: web-platform-tests/wpt#13818
--

wpt-commits: 4098fe5f1f08442a8d63db9eb107b49a2f4fe752
wpt-pr: 13769

UltraBlame original commit: afe5654fe9baae07072ff2384738e54bd29c1601
@lringnes

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants