Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid window.open in the test runner #13418

Closed
gsnedders opened this issue Oct 8, 2018 · 1 comment · Fixed by #13966 or #14506
Closed

Avoid window.open in the test runner #13418

gsnedders opened this issue Oct 8, 2018 · 1 comment · Fixed by #13966 or #14506
Assignees
@jgraham
Labels
infra priority:roadmap wptrunner The automated test runner, commonly called through ./wpt run

Comments

@gsnedders
Copy link
Member

From #12885 (comment) (@domenic, @TimothyGu).

See also discussion in #10398 (comment).

Note this is complicated for executors using WebDriver by the lack of any window management (beyond close) in WebDriver; see w3c/webdriver#1138.
@gsnedders gsnedders added infra wptrunner The automated test runner, commonly called through ./wpt run labels Oct 8, 2018
@gsnedders gsnedders assigned jgraham and unassigned gsnedders Nov 26, 2018
@jgraham jgraham mentioned this issue Nov 26, 2018
Merged
foolip added a commit that referenced this issue Dec 13, 2018
@foolip
Revert "Make testharness tests run in a top-level browsing context"
ce5b0bc 
This reverts commit 74522a2.

Fixes #14495.

Reopens #13418.
@foolip foolip mentioned this issue Dec 13, 2018
Merged
@foolip
Copy link
Member

foolip commented Dec 13, 2018

Reopening as #14496 was merged.

@foolip foolip reopened this Dec 13, 2018
foolip added a commit that referenced this issue Dec 13, 2018
@foolip
Revert "Make testharness tests run in a top-level browsing context" (#…
9377b49 
…14496)

This reverts commit 74522a2.

Fixes #14495.

Reopens #13418.
@jgraham jgraham mentioned this issue Dec 17, 2018
Merged
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this issue Jan 23, 2019
@moz-wptsync-bot @jgraham
Bug 1513880 [wpt PR 14496] - Revert "Make testharness tests run in a …
d71eda9 
…top-level browsing context", a=testonly

Automatic update from web-platform-tests
Revert "Make testharness tests run in a top-level browsing context" (#14496)

This reverts commit 74522a275bea481821e789145578e9e16fd27be3.

Fixes web-platform-tests/wpt#14495.

Reopens web-platform-tests/wpt#13418.
--

wpt-commits: 9377b490049c9af88ea0261ad3b92757733e8e95
wpt-pr: 14496


--HG--
rename : testing/web-platform/tests/tools/wptrunner/wptrunner/browsers/base.py => testing/web-platform/tests/tools/wptrunner/wptrunner/browsers/base.py.orig
rename : testing/web-platform/tests/tools/wptrunner/wptrunner/browsers/sauce.py => testing/web-platform/tests/tools/wptrunner/wptrunner/browsers/sauce.py.orig
mykmelez pushed a commit to mykmelez/gecko that referenced this issue Jan 23, 2019
@moz-wptsync-bot @jgraham
Bug 1513880 [wpt PR 14496] - Revert "Make testharness tests run in a …
1261c33 
…top-level browsing context", a=testonly

Automatic update from web-platform-tests
Revert "Make testharness tests run in a top-level browsing context" (#14496)

This reverts commit 74522a275bea481821e789145578e9e16fd27be3.

Fixes web-platform-tests/wpt#14495.

Reopens web-platform-tests/wpt#13418.
--

wpt-commits: 9377b490049c9af88ea0261ad3b92757733e8e95
wpt-pr: 14496
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this issue Oct 3, 2019
@marco-c
Bug 1513880 [wpt PR 14496] - Revert "Make testharness tests run in a …
e27ad7e 
…top-level browsing context", a=testonly

Automatic update from web-platform-tests
Revert "Make testharness tests run in a top-level browsing context" (#14496)

This reverts commit 74522a275bea481821e789145578e9e16fd27be3.

Fixes web-platform-tests/wpt#14495.

Reopens web-platform-tests/wpt#13418.
--

wpt-commits: 9377b490049c9af88ea0261ad3b92757733e8e95
wpt-pr: 14496

UltraBlame original commit: 0f0edff319bf9938e6ce47e62c586d2f25919263
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this issue Oct 3, 2019
@marco-c
Bug 1513880 [wpt PR 14496] - Revert "Make testharness tests run in a …
445a98d 
…top-level browsing context", a=testonly

Automatic update from web-platform-tests
Revert "Make testharness tests run in a top-level browsing context" (#14496)

This reverts commit 74522a275bea481821e789145578e9e16fd27be3.

Fixes web-platform-tests/wpt#14495.

Reopens web-platform-tests/wpt#13418.
--

wpt-commits: 9377b490049c9af88ea0261ad3b92757733e8e95
wpt-pr: 14496

UltraBlame original commit: 0f0edff319bf9938e6ce47e62c586d2f25919263
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this issue Oct 3, 2019
@marco-c
Bug 1513880 [wpt PR 14496] - Revert "Make testharness tests run in a …
463b9b4 
…top-level browsing context", a=testonly

Automatic update from web-platform-tests
Revert "Make testharness tests run in a top-level browsing context" (#14496)

This reverts commit 74522a275bea481821e789145578e9e16fd27be3.

Fixes web-platform-tests/wpt#14495.

Reopens web-platform-tests/wpt#13418.
--

wpt-commits: 9377b490049c9af88ea0261ad3b92757733e8e95
wpt-pr: 14496

UltraBlame original commit: 0f0edff319bf9938e6ce47e62c586d2f25919263
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jgraham jgraham

Labels
infra priority:roadmap wptrunner The automated test runner, commonly called through ./wpt run
Projects
None yet
Milestone
No milestone
3 participants
@gsnedders @jgraham @foolip