-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Testdriver: tabs switch frequently when invokes multiple actions #10398
Comments
Good catch, I'll take a look at this tomorrow. |
@kereliuk, should this be priority:roadmap, and has the state of things changed in the intervening months? Seems like this is the same window switching that's the reason that fullscreen can't be automated still? |
Will put on the list for this week, I think the priority should stay the same for now. |
This makes sure web platform tests for Picture-in-Picture do not time out when Picture-in-Picture API is not available. Besides, wpt/picture-in-picture/request-picture-in-picture is split to work around a flaky timeout in WPT upstream that's related to #10398 Note: based on #11329 Bug: 806249 Change-Id: I6185253dfa4aae5111e87553581b8464032558d1
This makes sure web platform tests for Picture-in-Picture do not time out when Picture-in-Picture API is not available. Besides, wpt/picture-in-picture/request-picture-in-picture is split to work around a flaky timeout in WPT upstream that's related to web-platform-tests/wpt#10398 Note: based on web-platform-tests/wpt#11329 Bug: 806249 Change-Id: I6185253dfa4aae5111e87553581b8464032558d1 Reviewed-on: https://chromium-review.googlesource.com/1107626 Reviewed-by: Robert Ma <[email protected]> Reviewed-by: Mounir Lamouri <[email protected]> Commit-Queue: François Beaufort <[email protected]> Cr-Commit-Position: refs/heads/master@{#576804}
This makes sure web platform tests for Picture-in-Picture do not time out when Picture-in-Picture API is not available. Besides, wpt/picture-in-picture/request-picture-in-picture is split to work around a flaky timeout in WPT upstream that's related to #10398 Note: based on #11329 Bug: 806249 Change-Id: I6185253dfa4aae5111e87553581b8464032558d1 Reviewed-on: https://chromium-review.googlesource.com/1107626 Reviewed-by: Robert Ma <[email protected]> Reviewed-by: Mounir Lamouri <[email protected]> Commit-Queue: François Beaufort <[email protected]> Cr-Commit-Position: refs/heads/master@{#576804}
This makes sure web platform tests for Picture-in-Picture do not time out when Picture-in-Picture API is not available. Besides, wpt/picture-in-picture/request-picture-in-picture is split to work around a flaky timeout in WPT upstream that's related to #10398 Note: based on #11329 Bug: 806249 Change-Id: I6185253dfa4aae5111e87553581b8464032558d1 Reviewed-on: https://chromium-review.googlesource.com/1107626 Reviewed-by: Robert Ma <[email protected]> Reviewed-by: Mounir Lamouri <[email protected]> Commit-Queue: François Beaufort <[email protected]> Cr-Commit-Position: refs/heads/master@{#576804}
…sts that time out., a=testonly Automatic update from web-platform-tests[Picture-in-Picture] Fix web platform tests that time out. This makes sure web platform tests for Picture-in-Picture do not time out when Picture-in-Picture API is not available. Besides, wpt/picture-in-picture/request-picture-in-picture is split to work around a flaky timeout in WPT upstream that's related to web-platform-tests/wpt#10398 Note: based on web-platform-tests/wpt#11329 Bug: 806249 Change-Id: I6185253dfa4aae5111e87553581b8464032558d1 Reviewed-on: https://chromium-review.googlesource.com/1107626 Reviewed-by: Robert Ma <[email protected]> Reviewed-by: Mounir Lamouri <[email protected]> Commit-Queue: François Beaufort <[email protected]> Cr-Commit-Position: refs/heads/master@{#576804} -- wpt-commits: 38ef6aad13a38e3dec8ca2c3783f9ab0575ad356 wpt-pr: 11589
…sts that time out., a=testonly Automatic update from web-platform-tests[Picture-in-Picture] Fix web platform tests that time out. This makes sure web platform tests for Picture-in-Picture do not time out when Picture-in-Picture API is not available. Besides, wpt/picture-in-picture/request-picture-in-picture is split to work around a flaky timeout in WPT upstream that's related to web-platform-tests/wpt#10398 Note: based on web-platform-tests/wpt#11329 Bug: 806249 Change-Id: I6185253dfa4aae5111e87553581b8464032558d1 Reviewed-on: https://chromium-review.googlesource.com/1107626 Reviewed-by: Robert Ma <[email protected]> Reviewed-by: Mounir Lamouri <[email protected]> Commit-Queue: François Beaufort <[email protected]> Cr-Commit-Position: refs/heads/master@{#576804} -- wpt-commits: 38ef6aad13a38e3dec8ca2c3783f9ab0575ad356 wpt-pr: 11589
I came across this in #12621. It makes it hard to see what's happening, and all that switching back and forth must have effects that may interfere with the tests. It's also the reason for #7281. @gsnedders, I'm wondering if we should bump the priority of this to "real soon now" and perhaps do together with #13183. Can you describe what it would take to change this? |
@foolip We'd need to change how testharness.js tests are run to not run them within a new window (see #12885 (comment)), given WebDriver can only deal with one window at a time. So:
|
I"m not 100% sure that's necessary. What's undoubtedly required is to stop sending commands to the parent window as the test runs. But it looks like that's possible without merging the windows into one. Maybe I'm missing something though. |
@jgraham if we're sending all the messages to the current window, what use does the parent window have? |
FWIW, if we could just not have the extra window that seems much preferable, since the use of |
Not having the window is possible but it's a larger change than required to fix this, with a different set of tradeoffs. |
@jgraham the parent window is used to receive the results of the testsuite, which would then need to go to the test window (given WebDriver would be listening to messages on the test window), so why do we still need the parent window? |
@jgraham responded to the above question at https://w3.logbot.info/testing/20181008#c446175 |
Ping from your friendly neighbourhood ecosystem infra rotation If this is |
This was fixed by #13419 |
…sts that time out., a=testonly Automatic update from web-platform-tests[Picture-in-Picture] Fix web platform tests that time out. This makes sure web platform tests for Picture-in-Picture do not time out when Picture-in-Picture API is not available. Besides, wpt/picture-in-picture/request-picture-in-picture is split to work around a flaky timeout in WPT upstream that's related to web-platform-tests/wpt#10398 Note: based on web-platform-tests/wpt#11329 Bug: 806249 Change-Id: I6185253dfa4aae5111e87553581b8464032558d1 Reviewed-on: https://chromium-review.googlesource.com/1107626 Reviewed-by: Robert Ma <robertmachromium.org> Reviewed-by: Mounir Lamouri <mlamourichromium.org> Commit-Queue: François Beaufort <beaufort.francoisgmail.com> Cr-Commit-Position: refs/heads/master{#576804} -- wpt-commits: 38ef6aad13a38e3dec8ca2c3783f9ab0575ad356 wpt-pr: 11589 UltraBlame original commit: 071bd4d29886a18128df2ce2dd60f4e150703838
…sts that time out., a=testonly Automatic update from web-platform-tests[Picture-in-Picture] Fix web platform tests that time out. This makes sure web platform tests for Picture-in-Picture do not time out when Picture-in-Picture API is not available. Besides, wpt/picture-in-picture/request-picture-in-picture is split to work around a flaky timeout in WPT upstream that's related to web-platform-tests/wpt#10398 Note: based on web-platform-tests/wpt#11329 Bug: 806249 Change-Id: I6185253dfa4aae5111e87553581b8464032558d1 Reviewed-on: https://chromium-review.googlesource.com/1107626 Reviewed-by: Robert Ma <robertmachromium.org> Reviewed-by: Mounir Lamouri <mlamourichromium.org> Commit-Queue: François Beaufort <beaufort.francoisgmail.com> Cr-Commit-Position: refs/heads/master{#576804} -- wpt-commits: 38ef6aad13a38e3dec8ca2c3783f9ab0575ad356 wpt-pr: 11589 UltraBlame original commit: 071bd4d29886a18128df2ce2dd60f4e150703838
…sts that time out., a=testonly Automatic update from web-platform-tests[Picture-in-Picture] Fix web platform tests that time out. This makes sure web platform tests for Picture-in-Picture do not time out when Picture-in-Picture API is not available. Besides, wpt/picture-in-picture/request-picture-in-picture is split to work around a flaky timeout in WPT upstream that's related to web-platform-tests/wpt#10398 Note: based on web-platform-tests/wpt#11329 Bug: 806249 Change-Id: I6185253dfa4aae5111e87553581b8464032558d1 Reviewed-on: https://chromium-review.googlesource.com/1107626 Reviewed-by: Robert Ma <robertmachromium.org> Reviewed-by: Mounir Lamouri <mlamourichromium.org> Commit-Queue: François Beaufort <beaufort.francoisgmail.com> Cr-Commit-Position: refs/heads/master{#576804} -- wpt-commits: 38ef6aad13a38e3dec8ca2c3783f9ab0575ad356 wpt-pr: 11589 UltraBlame original commit: 071bd4d29886a18128df2ce2dd60f4e150703838
I encountered this issue when trying to automate test at https://github.com/w3c/web-platform-tests/pull/10396/files#diff-52f806f8477bda3b3246226c740e6cb9
When invokes multiple
test_driver
actions, the runner will switch tab pages between test page and testharness_runner.html immediately and frequently(one action one switch).The text was updated successfully, but these errors were encountered: