Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-typed-om] Add support for marker properties. #10205

Merged
merged 1 commit into from
Mar 29, 2018

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Mar 28, 2018

This patch adds support for marker, marker-start, marker-end, marker-mid
We also had to add a new CSS data type , but because it's not
spec'd yet, we can't really test it.

Bug: 820299
Change-Id: Ie3f851be3d65396705594d99582ac3e87e3fc57d
Reviewed-on: https://chromium-review.googlesource.com/983192
Reviewed-by: Rune Lillesveen [email protected]
Commit-Queue: Darren Shen [email protected]
Cr-Commit-Position: refs/heads/master@{#546645}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already reviewed downstream.

@w3c-bots
Copy link

w3c-bots commented Mar 28, 2018

Build ERRORED

Started: 2018-03-28 23:15:46
Finished: 2018-03-29 00:06:45

Failing Jobs

  • firefox:nightly

View more information about this build on:

This patch adds support for marker, marker-start, marker-end, marker-mid
We also had to add a new CSS data type <url>, but because it's not
spec'd yet, we can't really test it.

Bug: 820299
Change-Id: Ie3f851be3d65396705594d99582ac3e87e3fc57d
Reviewed-on: https://chromium-review.googlesource.com/983192
Reviewed-by: Rune Lillesveen <[email protected]>
Commit-Queue: Darren Shen <[email protected]>
Cr-Commit-Position: refs/heads/master@{#546645}
@foolip
Copy link
Member

foolip commented Mar 29, 2018

Like #10191, this touches a shared testsuite.js and I believe the Firefox failure is due to #7660. Will merge manually.

@foolip foolip merged commit 604d17e into master Mar 29, 2018
@foolip foolip deleted the chromium-export-cl-983192 branch March 29, 2018 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants