Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automate more focus tests with testdriver #10396

Merged
merged 1 commit into from
Apr 11, 2018

Conversation

Honry
Copy link
Contributor

@Honry Honry commented Apr 10, 2018

Thanks to testdriver.js, we can automate more tests.

@kereliuk, could you PTAL?

@@ -2,17 +2,13 @@
<meta charset="utf-8">
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test fails due to #10398

Copy link
Contributor

@kereliuk kereliuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for automating these (and finding the bug).
Also your comments about TAB being '\ue004' has made me realize I should document where to find the escape codes in the testdriver docs. I will do that!

@Honry
Copy link
Contributor Author

Honry commented Apr 11, 2018

@kereliuk, thank you for your review. Merging it...

@Honry Honry merged commit 6934f15 into web-platform-tests:master Apr 11, 2018
@Honry Honry deleted the focus-automation branch April 11, 2018 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants