Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stability/verify unification #10988

Merged
merged 3 commits into from
Jun 5, 2018
Merged

stability/verify unification #10988

merged 3 commits into from
Jun 5, 2018

Conversation

gsnedders
Copy link
Member

@gsnedders gsnedders commented May 14, 2018 •
edited by wpt-reviewable-bot
Loading

Fixes #10921, and will fix #9874.

This change is Reviewable

@gsnedders gsnedders self-assigned this May 14, 2018
@wpt-pr-bot wpt-pr-bot requested a review from jgraham May 14, 2018 14:48
@gsnedders
Copy link
Member Author

Seems like I posted #9874 (comment) in the wrong place:

So what I haven't done so far is move over to running the multi-part verify (with/without restarts, with/without chaos mode in Firefox), but it does now use the verify code.

At the moment, it's still calling into the code through Python, rather than letting it run separately and then reading the logs. If we want to avoid going through the logs, we'd need to either make check_stability (in tools/wptrunner/wptrunner/stability.py) return something useful or call get_steps ourselves.

jgraham
jgraham requested changes May 23, 2018
View reviewed changes
Copy link
Contributor

@jgraham jgraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few small changes to request.

Can you push an unstable test, and a stable one, to this PR so that we can see how the travis output looks?

tools/wptrunner/wptrunner/wptcommandline.py Outdated
help="Run a stability check on the selected tests")
stability_group.add_argument("--stability", action="store_true",
default=False,
help="(DEPRECATED) Run a basic stability check on the selected tests")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can use help = argparse.SUPPRESS to remove this option from the help.

tools/wptrunner/wptrunner/wptrunner.py Outdated
@@ -302,6 +302,13 @@ def run_tests(config, test_paths, product, **kwargs):

def check_stability(**kwargs):
import stability
if kwargs["stability"]:
kwargs['verify_max_time'] = None
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe log a warning here.

@gsnedders
Copy link
Member Author

@jgraham now done; sorry I missed your comments before!

@foolip
Copy link
Member

foolip commented May 30, 2018

Can you push an unstable test, and a stable one, to this PR so that we can see how the travis output looks?

Ping @gsnedders

@gsnedders
Copy link
Member Author

Um, yeah, seems I deleted them locally. Now readded.

@gsnedders
Copy link
Member Author

(labelled because that commit needs to go before merging)

@foolip
Copy link
Member

foolip commented May 31, 2018

The Travis output looks about the same as before, so that seems to be working.

jgraham
jgraham approved these changes Jun 5, 2018
View reviewed changes
Copy link
Contributor

@jgraham jgraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the [DO NOT MERGE] commit :)

@gsnedders
Make check_stability.py use the --verify code
9a1fd95 
Note this doesn't yet address web-platform-tests#9874, as it currently only runs the
repeat_restart mode of --verify (as it did previously).
@gsnedders
Fix web-platform-tests#10921: make --stability use the same code as -…
88ef4da 
…-verify
@gsnedders
Make --verify-log-full not override log level
f0e8221
@gsnedders gsnedders merged commit d564a34 into web-platform-tests:master Jun 5, 2018
@gsnedders gsnedders deleted the stability-verify branch June 5, 2018 14:43
@foolip foolip mentioned this pull request Jun 11, 2018
Closed
gsnedders added a commit to gsnedders/web-platform-tests that referenced this pull request Jun 11, 2018
@gsnedders
Fix web-platform-tests#11454: Set --verify-log-full to False for ci/c…
31a9179 
…heck_stability.py

I'm not entirely sure why web-platform-tests#10988 made this default to on, given that
was a change of behaviour from before, so let's turn it back off
given it's causing breakage, as documented in web-platform-tests#11454.
@gsnedders gsnedders mentioned this pull request Jun 11, 2018
Merged
gsnedders added a commit that referenced this pull request Jun 12, 2018
@gsnedders
Fix #11454: Set --verify-log-full to False for ci/check_stability.py (#…
33280b7 
…11464)

I'm not entirely sure why #10988 made this default to on, given that
was a change of behaviour from before, so let's turn it back off
given it's causing breakage, as documented in #11454.
@foolip foolip mentioned this pull request Oct 7, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgraham jgraham jgraham approved these changes

Assignees

@gsnedders gsnedders

Labels
infra
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make --stability just use the --verify code Move stability checking to wpt run --verify
4 participants
@gsnedders @foolip @jgraham @wpt-pr-bot