Improve RTCPeerConnection-setRemoteDescription-tracks.https.html tests. #11301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Jun 1, 2018
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1082434
branch
3 times, most recently
from
47f9356
to
e423c81
Compare
Using async functions and promise_tests instead of then()-chains and async_tests. This makes them more readable, easier to maintain and shorter. Replaced RTCPeerConnection-helper.js function performOffer() with exchangeOffer()/exchangeAnswer()/exchangeOfferAnswer(). Updated tests that were performing multiple offers to perform a full offer/answer exchange whenever there were future offers to be made. Previously it would perform half of an offer/answer cycle before starting the next offer/answer, which under Unified Plan could lead to some unexpected failures. [email protected] Bug: 777617 Change-Id: Ib0305d55af5aef7f49b5418d4ba44ded9c84d5c6 Reviewed-on: https://chromium-review.googlesource.com/1082434 Reviewed-by: Henrik Boström <[email protected]> Commit-Queue: Henrik Boström <[email protected]> Cr-Commit-Position: refs/heads/master@{#565234}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1082434
branch
from
e423c81
to
f9d9a1b
Compare
|
Travis failure due to #11454, force merging this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using async functions and promise_tests instead of then()-chains and
async_tests. This makes them more readable, easier to maintain and
shorter.
Replaced RTCPeerConnection-helper.js function performOffer() with
exchangeOffer()/exchangeAnswer()/exchangeOfferAnswer().
Updated tests that were performing multiple offers to perform a full
offer/answer exchange whenever there were future offers to be made.
Previously it would perform half of an offer/answer cycle before
starting the next offer/answer, which under Unified Plan could lead to
some unexpected failures.
TBR=[email protected]
Bug: 777617
Change-Id: Ib0305d55af5aef7f49b5418d4ba44ded9c84d5c6
Reviewed-on: https://chromium-review.googlesource.com/1082434
Reviewed-by: Henrik Boström [email protected]
Commit-Queue: Henrik Boström [email protected]
Cr-Commit-Position: refs/heads/master@{#565234}