Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update existing tests as per https://github.com/web-platform-tests/wpt/pull/13499 #14418

Conversation

youennf
Copy link
Contributor

@youennf youennf commented Dec 7, 2018

This PR takes #13499 changes from existing tests and move them to a separate PR.

@youennf
Copy link
Contributor Author

youennf commented Dec 7, 2018

Some of the newly added tests require a change to createDataChannelPair in RTCPeerConnection-helpers.js.
@lgrahl, would you be able to update in this PR RTCPeerConnection-helpers.js with the new functionality required for createDataChannelPair?

The alternative might be that I remove the tests using this new functionality to allow merging the other changes.
I do not think we should work around Safari bugs as in #13499.

@youennf
Copy link
Contributor Author

youennf commented Dec 7, 2018

This PR does not contain PR #13499 changes related to RTCSctpTransport-constructor.html as they were conflicting with other changes that landed already.
@lgrahl, if you can file a separate PR for these specific changes, that would be nice.

@youennf
Copy link
Contributor Author

youennf commented Dec 7, 2018

PR not yet ready to be merged.

@lgrahl
Copy link

lgrahl commented Dec 8, 2018

I've compared the changes to my branch and I'm confused by the changes that have been made to it.

  1. I'm seeing a syntax error in RTCDataChannel-bufferedAmount.html.
  2. The resolver is not being awaited any longer in RTCPeerConnection-ondatachannel.html. The test ends prematurely.
  3. The local timeout stuff and the global timeout disabler I added still exist.

Thus, I took this branch and rebased it, added the required functionality to RTCPeerConnection-helper.js, added the RTCSctpTransport tests and removed the local timeouts. See #14424.

@youennf
Copy link
Contributor Author

youennf commented Dec 8, 2018

@lgrahl, thanks for taking over in #14424.
Let's close this one then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants