Update existing data channel tests #14424
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Originally from web-platform-tests#13499
Remove local timeouts from tests Fiddle with timeout values Fix a couple of issues related to switching to `Resolver`
wpt-pr-bot
requested review from
agouaillard,
alvestrand,
dontcallmedom,
guidou,
henbos,
jan-ivar,
phoglund,
rwaldron,
snuggs and
youennf
|
This PR is blocked on the required "Travis CI - Pull Request" check after #14499. In order to trigger it, I will close and reopen this PR. |
|
Needs rebase. |
|
Some tests of webrtc/RTCDataChannel-id.html are timing out in Chrome, Firefox and Safari. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split updates to existing/short tests from new/long tests (see #13499). Supersedes #14418.
Don't merge before these boxes are ticked:
@alvestrand @youennf please take a look and if you're happy with the changes I'll port the rest. I've removed the explicit local timeouts as requested and fiddled a bit with the timeouts.