Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created 6 improved tests #20931

Closed
wants to merge 3 commits into from

Conversation

TalbotG
Copy link
Contributor

@TalbotG TalbotG commented Dec 28, 2019

active-selection-021.html
active-selection-021-ref.html
active-selection-024.html
active-selection-024-ref.html
active-selection-031.html
active-selection-031-ref.html
active-selection-041.html
active-selection-041-ref.html
active-selection-043.html
active-selection-045.html
support/60x60-red.png
support/60x60-green.png
support/100x100-red.png
reference/ref-filled-green-100px-square.xht
reference/ref-nothing-below.xht

This PR is a followup to
#20028

This PR contains all the corrections and improvements proposed in #20028

@TalbotG
Copy link
Contributor Author

TalbotG commented Dec 28, 2019

@fantasai , please review .

@TalbotG
Copy link
Contributor Author

TalbotG commented Jan 27, 2020

@fantasai ,

active-selection-024: improved test, first-letter

active-selection-025: new test, first-letter, no color declaration only background-color

active-selection-026: new test, first-line

active-selection-027: new test, first-line, no color declaration only background-color

These 4 tests take into account the resolution in
w3c/csswg-drafts#4625

@TalbotG TalbotG removed the request for review from plinss May 5, 2020 19:34
@TalbotG TalbotG requested a review from fantasai June 15, 2020 22:58
@fantasai
Copy link
Contributor

@TalbotG Remove the replaced element tests from this PR, because the rest of these are are acceptable tests, but 41 and 43 are not.

The transparency of the color wash is not dictated by the spec and each UA has their own color, so your approach is not valid. See #20028 (review) for an approach that will actually work to test this case. File a new, separate PR for the replaced element tests.

Copy link
Contributor

@fantasai fantasai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment above.

@TalbotG
Copy link
Contributor Author

TalbotG commented Jul 24, 2020

I must close this PR and delete this branch now that
#24713
#24714
have merged.

I will create a distinct and separate PR for
active-selection-041.html
active-selection-041-ref.html
active-selection-043.html

I have bookmarked your
web-platform-tests wpt pull 20931#issuecomment-650434204

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants