-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Created 6 improved tests #20931
Created 6 improved tests #20931
Conversation
@fantasai , please review . |
active-selection-024: improved test, first-letter active-selection-025: new test, first-letter, no active-selection-026: new test, first-line active-selection-027: new test, first-line, no These 4 tests take into account the resolution in |
@TalbotG Remove the replaced element tests from this PR, because the rest of these are are acceptable tests, but 41 and 43 are not. The transparency of the color wash is not dictated by the spec and each UA has their own color, so your approach is not valid. See #20028 (review) for an approach that will actually work to test this case. File a new, separate PR for the replaced element tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comment above.
active-selection-021.html
active-selection-021-ref.html
active-selection-024.html
active-selection-024-ref.html
active-selection-031.html
active-selection-031-ref.html
active-selection-041.html
active-selection-041-ref.html
active-selection-043.html
active-selection-045.html
support/60x60-red.png
support/60x60-green.png
support/100x100-red.png
reference/ref-filled-green-100px-square.xht
reference/ref-nothing-below.xht
This PR is a followup to
#20028
This PR contains all the corrections and improvements proposed in #20028