Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added 2 active-selection-* tests #24714

Merged
merged 3 commits into from
Jul 24, 2020
Merged

Added 2 active-selection-* tests #24714

merged 3 commits into from
Jul 24, 2020

Conversation

TalbotG
Copy link
Contributor

@TalbotG TalbotG commented Jul 23, 2020

active-selection-031.html
reference/active-selection-031-ref.html

active-selection-045.html

support/100x100-red.png

This is the 2nd half of
#24710

@TalbotG TalbotG mentioned this pull request Jul 23, 2020
Closed
@TalbotG TalbotG removed the request for review from plinss July 23, 2020 04:29
@TalbotG TalbotG assigned TalbotG and unassigned plinss Jul 23, 2020
@TalbotG TalbotG requested a review from fantasai July 23, 2020 05:16
This was referenced Jul 23, 2020
Closed
Closed
@jgraham
Copy link
Contributor

jgraham commented Jul 24, 2020

You need to remove the reftest-wait at the point you actually want the screenshot to happen (i.e. after all the necessary script has run).

@TalbotG TalbotG merged commit 2b2864e into web-platform-tests:master Jul 24, 2020
@TalbotG TalbotG deleted the CSS4Pseudo-GT-PR29 branch July 24, 2020 17:27
This was referenced Jul 24, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fantasai fantasai fantasai approved these changes

@frivoal frivoal Awaiting requested review from frivoal

Assignees

@TalbotG TalbotG

Labels
css-pseudo
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@TalbotG @jgraham @fantasai @plinss @wpt-pr-bot