Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update interfaces/native-file-system.idl #22162

Conversation

autofoolip
Copy link
Contributor

@autofoolip autofoolip commented Mar 10, 2020

This PR was automatically created by a bot.

Before merging, please check that any tests that depend on the updated IDL files still work.

If additional changes are needed, please manually create another PR based on this one.

See the README for how the IDL files in this directory are used.


Source: https://github.com/tidoust/reffy-reports/blob/14fca71/ed/idl/native-file-system.idl
Build: https://travis-ci.org/tidoust/reffy-reports/builds/692042822

@stephenmcgruer
Copy link
Contributor

Fun, this introduces a dependency on 'WritableStream', but we don't have any such interface in interfaces/:

$ grep -r WritableStream interfaces/
interfaces/encoding.idl:  readonly attribute WritableStream writable;

Looking at the spec (https://wicg.github.io/native-file-system/) and then following the link for WritableStream (https://streams.spec.whatwg.org/#ws-class), it's non-normative and has no IDL!

@autofoolip autofoolip force-pushed the reffy-reports/native-file-system branch from ec507ee to 5b39eb8 Compare March 23, 2020 18:40
@autofoolip autofoolip force-pushed the reffy-reports/native-file-system branch from 5b39eb8 to 622ed61 Compare April 18, 2020 00:42
@autofoolip autofoolip force-pushed the reffy-reports/native-file-system branch from 622ed61 to 54be5f1 Compare May 5, 2020 18:40
@autofoolip autofoolip force-pushed the reffy-reports/native-file-system branch from 54be5f1 to 0648a7e Compare May 28, 2020 06:38
@mkruisselbrink
Copy link
Contributor

What can be done to unblock this? Not having any idlharness tests for the native file system API seems better than the current state where the tests in way reflect what is actually in the spec. And that will only diverge more and more as the spec and implementation get updated...

@stephenmcgruer
Copy link
Contributor

I believe @domenic was looking into converting streams to IDL, which would trivially fix the issue. Failing that, I need to look at how fatal an error this is for idlharness and how we might work around it...

@domenic
Copy link
Member

domenic commented Jun 9, 2020

Streams IDL conversion is almost ready to merge in #22982.

stephenmcgruer added a commit that referenced this pull request Jun 11, 2020
foolip pushed a commit that referenced this pull request Jun 11, 2020
@autofoolip autofoolip deleted the reffy-reports/native-file-system branch June 12, 2020 00:40
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Jun 17, 2020
… and test, a=testonly

Automatic update from web-platform-tests
Update interfaces/native-file-system.idl and test (#24121)

Closes web-platform-tests/wpt#22162
--

wpt-commits: 553ab1a48e7d387b5d78f79444525376a931bb76
wpt-pr: 24121
xeonchen pushed a commit to xeonchen/gecko that referenced this pull request Jun 18, 2020
… and test, a=testonly

Automatic update from web-platform-tests
Update interfaces/native-file-system.idl and test (#24121)

Closes web-platform-tests/wpt#22162
--

wpt-commits: 553ab1a48e7d387b5d78f79444525376a931bb76
wpt-pr: 24121
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants