-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Streams: update tests for Web IDL conversion #22982
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
The removed tests will be done by idlharness.js, so we definitely don't want to keep them.
As you say, it would be good to verify that the second argument is unpacked before the second, but we don't need all this infrastructure to do it, just something like
assert_throws_exact(error2,
() => new ReadableStream({ get start() { throw error1; } }, { get size() { throw error2; } }));
should do it.
Everything still lgtm. I don't know what to do about ReadableStreamBYOBRequest. Could we just call idl_test() asynchronously after grabbing one? |
7677c83
to
2c5ebb9
Compare
2c5ebb9
to
3008aae
Compare
Looks like TaskCluster didn't run here, retrying. |
This is a draft PR, TaskCluster doesn't run on drafts. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I re-reviewed everything. Still lgtm.
Needs Web IDL spec update
Updates lgtm. |
Spec discussions ongoing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The recent additions around next
/return
interactions look good, modulo one nit. Also, would it be a good idea to have an assert_iteration_result()
, perhaps for future?
The new idlharness tests for Streams (#22982) did not correctly instantiate all tested interfaces. This PR fixes them.
Follows whatwg/streams#1035. Notable changes:
start()
function, then waiting on that before doing asserts, does not work with Web IDL's "promise resolved with". So instead we useflushAsyncEvents()
to wait a little longer.