Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test Symbol.toStringTag value of namespace objects #24717

Merged
merged 3 commits into from
Jul 23, 2020
Merged

Test Symbol.toStringTag value of namespace objects #24717

merged 3 commits into from
Jul 23, 2020

Conversation

shvaikalesh
Copy link
Member

@shvaikalesh shvaikalesh mentioned this pull request Jul 23, 2020
Merged
domenic
domenic approved these changes Jul 23, 2020
View reviewed changes
Copy link
Member

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! We could do this in idlharness instead, but I'm happy with this for now, and we can tackle consolidation as part of #23206.

@domenic
Copy link
Member

domenic commented Jul 23, 2020

Per https://community-tc.services.mozilla.com/tasks/IPkLC1xwS2KAjIzOhr8DNg/runs/0/logs/https%3A%2F%2Fcommunity-tc.services.mozilla.com%2Fapi%2Fqueue%2Fv1%2Ftask%2FIPkLC1xwS2KAjIzOhr8DNg%2Fruns%2F0%2Fartifacts%2Fpublic%2Flogs%2Flive.log#L129 it looks like files in the CSS/ folder have extra requirements around some sort of link... try to look around nearby to see if we can figure that out?

domenic pushed a commit to whatwg/webidl that referenced this pull request Jul 23, 2020
@shvaikalesh
Install @@toStringTag on namespace objects
d7145e2 
A followup to #357.

This change aligns WebIDL namespace objects with ECMA-262 ones, per tc39/ecma262#2057 (comment).

Tests: web-platform-tests/wpt#24717
@shvaikalesh shvaikalesh force-pushed the webidl-namespace-object-class-string branch from 6cb6d46 to 791d495 Compare July 23, 2020 15:27
@shvaikalesh
Copy link
Member Author

According to https://web-platform-tests.org/writing-tests/lint-tool.html, MISSING-LINK lint rule requires *.html testcase files; renamed & rebased.

@domenic domenic merged commit 3b1f72e into web-platform-tests:master Jul 23, 2020
caiolima pushed a commit to caiolima/webkit that referenced this pull request Aug 25, 2020
Console object's @@toStringTag should be "console" instead of "Console"
d0e4c24 
https://bugs.webkit.org/show_bug.cgi?id=215750

Reviewed by Ross Kirsling.

LayoutTests/imported/w3c:

Import ToT wpt/console tests including @@toStringTag tests.

* resources/import-expectations.json:
* web-platform-tests/console/META.yml: Added.
* web-platform-tests/console/console-is-a-namespace.any-expected.txt: Added.
* web-platform-tests/console/console-is-a-namespace.any.html: Added.
* web-platform-tests/console/console-is-a-namespace.any.js: Added.
(test):
* web-platform-tests/console/console-is-a-namespace.any.worker-expected.txt: Added.
* web-platform-tests/console/console-is-a-namespace.any.worker.html: Added.
* web-platform-tests/console/console-label-conversion.any-expected.txt: Added.
* web-platform-tests/console/console-label-conversion.any.html: Added.
* web-platform-tests/console/console-label-conversion.any.js: Added.
(const.method.of.methods.test):
* web-platform-tests/console/console-label-conversion.any.worker-expected.txt: Added.
* web-platform-tests/console/console-label-conversion.any.worker.html: Added.
* web-platform-tests/console/console-namespace-object-class-string.any-expected.txt: Added.
* web-platform-tests/console/console-namespace-object-class-string.any.html: Added.
* web-platform-tests/console/console-namespace-object-class-string.any.js: Added.
(test):
(test.t.t.add_cleanup):
* web-platform-tests/console/console-namespace-object-class-string.any.worker-expected.txt: Added.
* web-platform-tests/console/console-namespace-object-class-string.any.worker.html: Added.
* web-platform-tests/console/console-tests-historical.any-expected.txt: Added.
* web-platform-tests/console/console-tests-historical.any.html: Added.
* web-platform-tests/console/console-tests-historical.any.js: Added.
(test):
* web-platform-tests/console/console-tests-historical.any.worker-expected.txt: Added.
* web-platform-tests/console/console-tests-historical.any.worker.html: Added.
* web-platform-tests/console/idlharness.any-expected.txt: Added.
* web-platform-tests/console/idlharness.any.html: Added.
* web-platform-tests/console/idlharness.any.js: Added.
* web-platform-tests/console/idlharness.any.worker-expected.txt: Added.
* web-platform-tests/console/idlharness.any.worker.html: Added.
* web-platform-tests/console/w3c-import.log: Added.

Source/JavaScriptCore:

Use "console" instead of "Console". Now, namespace object has @@toStringTag.
web-platform-tests/wpt#24717

* runtime/ConsoleObject.cpp:

LayoutTests:

* fast/dom/Window/window-lookup-precedence-expected.txt:
* fast/loader/window-properties-restored-from-page-cache-expected.txt:
* http/tests/security/cross-frame-access-put-expected.txt:
* inspector/debugger/pause-for-internal-scripts-expected.txt:
* inspector/debugger/stepping/stepping-internal-scripts-expected.txt:
* js/console-expected.txt:
* js/console.html:
* platform/gtk/fast/dom/Window/window-lookup-precedence-expected.txt:
* platform/mac-wk2/fast/dom/Window/window-lookup-precedence-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@266030 268f45cc-cd09-0410-ab3c-d52691b4dbfc
@Leko Leko mentioned this pull request Sep 28, 2020
Closed
3 tasks
Leko added a commit to nodejs/node that referenced this pull request Oct 1, 2020
@Leko
console: add Symbol.toStringTag property
4a6005c 
Add Symbol.toStringTag property to console object to follow WPT changes
Update WPT status of console and the repl test case

Refs: web-platform-tests/wpt#24717

PR-URL: #35399
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Zeyu Yang <[email protected]>
Reviewed-By: James M Snell <[email protected]>
danielleadams pushed a commit to nodejs/node that referenced this pull request Oct 6, 2020
@Leko @danielleadams
console: add Symbol.toStringTag property
05e08bd 
Add Symbol.toStringTag property to console object to follow WPT changes
Update WPT status of console and the repl test case

Refs: web-platform-tests/wpt#24717

PR-URL: #35399
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Zeyu Yang <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit to nodejs/node that referenced this pull request Nov 3, 2020
@Leko @MylesBorins
console: add Symbol.toStringTag property
d54c67a 
Add Symbol.toStringTag property to console object to follow WPT changes
Update WPT status of console and the repl test case

Refs: web-platform-tests/wpt#24717

PR-URL: #35399
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Zeyu Yang <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit to nodejs/node that referenced this pull request Nov 16, 2020
@Leko @MylesBorins
console: add Symbol.toStringTag property
2e766a6 
Add Symbol.toStringTag property to console object to follow WPT changes
Update WPT status of console and the repl test case

Refs: web-platform-tests/wpt#24717

PR-URL: #35399
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Zeyu Yang <[email protected]>
Reviewed-By: James M Snell <[email protected]>
joesepi pushed a commit to joesepi/node that referenced this pull request Jan 8, 2021
@Leko @joesepi
console: add Symbol.toStringTag property
ffcc985 
Add Symbol.toStringTag property to console object to follow WPT changes
Update WPT status of console and the repl test case

Refs: web-platform-tests/wpt#24717

PR-URL: nodejs#35399
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Zeyu Yang <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@domenic domenic domenic approved these changes

@dbaron dbaron Awaiting requested review from dbaron

@domfarolino domfarolino Awaiting requested review from domfarolino

@lilles lilles Awaiting requested review from lilles

@Ms2ger Ms2ger Awaiting requested review from Ms2ger

@plinss plinss Awaiting requested review from plinss

@pwnall pwnall Awaiting requested review from pwnall

@titzer titzer Awaiting requested review from titzer

Assignees

@titzer titzer

Labels
console cssom wasm wg-css
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shvaikalesh @domenic @titzer @wpt-pr-bot