Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ResourceTiming style guide to explain asserts vs. errors #27707

Merged
merged 1 commit into from
Feb 22, 2021
Merged

Update ResourceTiming style guide to explain asserts vs. errors #27707

merged 1 commit into from
Feb 22, 2021

Commits on Feb 22, 2021

  1. Update ResourceTiming style guide to explain asserts vs. errors 

    In ResourceTiming Web Platform Tests, we want to use assertion failures
to indicate divergence from the spec but use exceptions to indicate
issues with the test code.

This change updates the style guide to call out this goal.

Bug: 1171767
Change-Id: If9df3b05de75cbb516bc5c9f1ac0897abac0b4ab
GithubIssue: w3c/resource-timing#254
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2707184
Commit-Queue: Tom McKee <[email protected]>
Reviewed-by: Yoav Weiss <[email protected]>
Reviewed-by: Steve Kobes <[email protected]>
Cr-Commit-Position: refs/heads/master@{#856285}
    @tommckee1 @chromium-wpt-export-bot
    tommckee1 authored and chromium-wpt-export-bot committed Feb 22, 2021
    Configuration menu
    Copy the full SHA
    e6941b1 View commit details
    Browse the repository at this point in the history