[resource timing] Improve document.domain tests #28901
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
May 7, 2021
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2878852
branch
from
ac15241
to
1d84516
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2878852
branch
2 times, most recently
from
5774bcb
to
787737b
Compare
Bug: 1171767 Change-Id: Ic6fe541d575d365070cae865f0cde1f6407d01d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2878852 Reviewed-by: Tom McKee <[email protected]> Reviewed-by: Nicolás Peña Moreno <[email protected]> Commit-Queue: Yoav Weiss <[email protected]> Cr-Commit-Position: refs/heads/master@{#881193}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2878852
branch
from
787737b
to
fe32983
Compare
|
Closing this PR because it has been reverted |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug: 1171767
Change-Id: Ic6fe541d575d365070cae865f0cde1f6407d01d9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2878852
Reviewed-by: Tom McKee <[email protected]>
Reviewed-by: Nicolás Peña Moreno <[email protected]>
Commit-Queue: Yoav Weiss <[email protected]>
Cr-Commit-Position: refs/heads/master@{#881193}
Revert "[resource timing] Improve document.domain tests"
This reverts commit 0d2ce9c24b1177ab4acdb1daf2223776656dc7ce.
Reason for revert: Caused blink_web_tests to fail on multiple platforms
e.g.
https://ci.chromium.org/ui/p/chromium/builders/ci/Mac10.14%20Tests/15434/overview
Filed https://crbug.com/1207866
Bug: 1171767
Change-Id: I1743add973a980eaffc0ade58f9588d31bccbfa7
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2885046
Bot-Commit: Rubber Stamper [email protected]
Commit-Queue: Marc Treib [email protected]
Reviewed-by: Marc Treib [email protected]
Reviewed-by: Mohamed Amir Yosef [email protected]
Owners-Override: Mohamed Amir Yosef [email protected]
Auto-Submit: Mohamed Amir Yosef [email protected]
Cr-Commit-Position: refs/heads/master@{#881470}