-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[resource timing] Improve document.domain tests (reland) #28965
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The review process for this patch is being conducted in the Chromium project.
e6a2f4c
to
b9778c9
Compare
This CL is a fixed up reland of [1], which was reverted due to a rename in entry-invariants.js that it was relying on. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2878852 Bug: 1171767, 1208054 Change-Id: I436bf6973e4399d142ce45e77c07f26d0e7e1cd1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2888667 Reviewed-by: Tom McKee <[email protected]> Commit-Queue: Yoav Weiss <[email protected]> Cr-Commit-Position: refs/heads/master@{#881945}
b9778c9
to
1afbd7a
Compare
@jpchase timeout on Firefox and Chrome and seems to be unrelated. Could you admin merge? |
I would agree, except the reverted version of the PR (#28901) also had timeouts that appear to be similar: Meanwhile, other PRs have recently ran successfully (e.g. #28963). @KyleJu would you rebase and rerun the checks on this PR? I'd like to see if that can rule out the timeout being somehow related to these changes (even though we don't have reason to suspect so). |
…ium-export-cl-2888667
Note that Chrome/Firefox checks are running against PR changes. so #28963 is probably not indicative of the status of checks in this PR because they are running different sets of tests. I am suspecting
Yea rebase and rerun sound like a good idea. |
Perhaps there are multiple things going on here, but I see at least some of the stability jobs have timed out, which is #7660. When this happens, I just link to that issue and admin merge. @past FYI, this is a pretty common source of issues, and pretty high up on my list of things we should fix in WPT CI. |
@jpchase Still timing out. I think we can admin merge this PR |
Yes, agreed to admin merge. |
This CL is a fixed up reland of [1], which was reverted due to a rename
in entry-invariants.js that it was relying on.
[1] https://chromium-review.googlesource.com/c/chromium/src/+/2878852
Bug: 1171767, 1208054
Change-Id: I436bf6973e4399d142ce45e77c07f26d0e7e1cd1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2888667
Reviewed-by: Tom McKee <[email protected]>
Commit-Queue: Yoav Weiss <[email protected]>
Cr-Commit-Position: refs/heads/master@{#881945}