Add <popup> light dismiss behavior when <popup> is resized #28963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
May 11, 2021
Per the explainer [1] a <popup> should hide itself if it gets resized. This CL implements that behavior. The existing test had a few bugs, so I also updated it. Bug: 1168738 Change-Id: Id304737ef768d96509e3968c29fa76e0bd93acc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2889473 Auto-Submit: Mason Freed <[email protected]> Commit-Queue: Ionel Popescu <[email protected]> Reviewed-by: Ionel Popescu <[email protected]> Cr-Commit-Position: refs/heads/master@{#882137}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2889473
branch
from
620b8dd
to
f9a1ba2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per the explainer [1] a <popup> should hide itself if it gets resized.
This CL implements that behavior. The existing test had a few bugs,
so I also updated it.
Bug: 1168738
Change-Id: Id304737ef768d96509e3968c29fa76e0bd93acc8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2889473
Auto-Submit: Mason Freed <[email protected]>
Commit-Queue: Ionel Popescu <[email protected]>
Reviewed-by: Ionel Popescu <[email protected]>
Cr-Commit-Position: refs/heads/master@{#882137}