Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test the javascript: URL security check #29468

Merged
merged 3 commits into from
Jun 25, 2021
Merged

Conversation

domenic
Copy link
Member

@domenic domenic commented Jun 23, 2021

Follows whatwg/html#6801.

@annevk
Copy link
Member

annevk commented Jun 25, 2021

I don't understand the expectations for the case where one side sets document.domain. document.domain does not influence the same origin check. It only influences same origin-domain. So browsers that fail that test would be doing the same origin check, right?

It might be good to also test what happens with same-site cross-origin and both sides setting document.domain.

@domenic
Copy link
Member Author

domenic commented Jun 25, 2021

You're right that the expectations didn't match the spec. I updated the spec though so I think the tests are now good.

It might be good to also test what happens with same-site cross-origin and both sides setting document.domain.

Done.

Copy link
Member

@annevk annevk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@domenic domenic merged commit da61c71 into master Jun 25, 2021
@domenic domenic deleted the javascript-url-origin-check branch June 25, 2021 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants