Fix javascript: URL origin security check #6801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domenic
added
topic: navigation
security/privacy
|
From your tests I get the impression the browsers do the opposite of what you assert. You can only get a same origin-domain match if both sides have set |
|
You are totally right. Let me change the check to same origin-domain then. |
|
(In particular same origin-domain makes more sense here anyway, since if you have synchronous access to the document then you can just run JS in it directly.) |
annevk
approved these changes
Jun 25, 2021
domenic
added a commit
to web-platform-tests/wpt
that referenced
this pull request
Jun 25, 2021
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Jun 27, 2021
… a=testonly Automatic update from web-platform-tests Test the javascript: URL security check Follows whatwg/html#6801. -- wpt-commits: da61c71b9417336421d5b0f8b8973a7225d5815b wpt-pr: 29468
jamienicol
pushed a commit
to jamienicol/gecko
that referenced
this pull request
Jul 16, 2021
… a=testonly Automatic update from web-platform-tests Test the javascript: URL security check Follows whatwg/html#6801. -- wpt-commits: da61c71b9417336421d5b0f8b8973a7225d5815b wpt-pr: 29468
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it non-racy by taking the origin snapshotted at the top of the navigation algorithm. It also switches to same origin-domain, which is more reasonable since if you have synchronous access to the document then you can just run JavaScript directly in it anyway. Fixes #2591. Helps with #1130. See #6514 for related investigation.
(See WHATWG Working Mode: Changes for more details.)
/browsing-the-web.html ( diff )