Fix some shadow root tests

[sarvaje]

This PR fix some remaining issues in the tests for the shadow root commands:

• Get Element Shadow Root
• Find Element From Shadow Root
• Find Elements From Shadow Root

[sarvaje]

Hi, this is my first contribution and I can find why the tasks are failing. Can you help me, please?

[mathiasbynens]

(For context, this patch is blocking https://chromium-review.googlesource.com/c/chromium/src/+/3033190.)

[foolip]

@sarvaje what you've run into is #7660. Due to the tests that have been modified, probably too many other tests are considered affected and run 10 times. But there's not enough time to run the 10 times, so both of the task logs end with "Task timeout after 7200 seconds. Force killing container.":
https://community-tc.services.mozilla.com/tasks/McbMml-mQByDrxWWwHiE8w/runs/0/logs/public/logs/live.log
https://community-tc.services.mozilla.com/tasks/L5eda_kSTOKaDau2omgoCQ/runs/0/logs/public/logs/live.log

When this happens, the only recourse is to ping @web-platform-tests/admins asking someone to admin merge, basically ignoring the failed CI checks.

If the tests are in order and you have a review but can't merge it, feel free to ping me or @past for merging.

[sarvaje]

@foolip Thanks for your answer, before pinging @web-platform-tests/admins for the merge, should I wait for someone to approve my changes, right?

[foolip]

Right, you'll need someone to review the actual changes here. In all honestly that probably won't happen by just waiting, so you might want to look at who has recently written or reviewed tests close to these and ping them directly until you find a reviewer.

[sarvaje]

Ok, thanks!!

[sarvaje]

@whimboo I see you reviewed the PR that added the Shadow root tests. Can you take a look to my PR too? Thanks!

[whimboo]

Thanks a lot for your contribution! It's great to see these obvious mistakes to be fixed soon. Nevertheless I added some inline comments that have to be looked at.

[whimboo]

Looks fine to me now.

[sarvaje]

Thanks @whimboo.
The checks failing are because of a timeout. @foolip mention that I can ping @web-platform-tests/admins to bypass the checks and get the PR merged. How can I ping them, github doesn't recognize @web-platform-tests/admins as a know group or anything hehehe.

[whimboo]

Actually tests fail because of the changes to the Element class:

url = '/session/84b28476-db5d-488a-8bb4-da75dde1ec5f/element/<Session 84b28476-db5d-488a-8bb4-da75dde1ec5f>/value'

As such please revert these, to not cause massive extra work.

[sarvaje]

As such please revert these, to not cause massive extra work.

done

[whimboo]

Yes, all tests passing now and stability ones timeout as expected. Thanks!