Make popups animation-friendly #34304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Jun 3, 2022
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3688871
branch
7 times, most recently
from
ae64714
to
15bf248
Compare
Now, popups will follow this process when showing/hiding:
showPopup():
1. Move the popup to the top layer, and remove the UA display:none
style.
2. Update style. (Transition initial style can be specified in this
state.)
3. Set the :top-layer pseudo class.
4. Update style. (Animations/transitions happen here.)
hidePopup():
1. Capture any already-running animations via getAnimations().
2. Remove the :top-layer pseudo class.
3. Update style. (Animations/transitions start here.)
4. If the hidePopup() call is not due to a "force out" situation,
getAnimations() again, remove any from step #1, and then wait here
until all of them finish or are cancelled.
4. Remove the popup from the top layer, and add the UA display:none
style.
5. Update style.
See this issue for more details:
openui/open-ui#335
Bug: 1307772
Change-Id: Ia20eb6e9533c1a0b1029ca1279d42fe2648300af
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3688871
Reviewed-by: Robert Flack <[email protected]>
Commit-Queue: Mason Freed <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1014235}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3688871
branch
from
15bf248
to
cdc0cdc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now, popups will follow this process when showing/hiding:
showPopup():
style.
state.)
hidePopup():
getAnimations() again, remove any from step Aryeh's submission #1, and then wait here
until all of them finish or are cancelled.
style.
See this issue for more details:
openui/open-ui#335
Bug: 1307772
Change-Id: Ia20eb6e9533c1a0b1029ca1279d42fe2648300af
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3688871
Reviewed-by: Robert Flack <[email protected]>
Commit-Queue: Mason Freed <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1014235}