Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make popups animation-friendly #34304

Merged
merged 1 commit into from
Jun 15, 2022

Commits on Jun 15, 2022

  1. Make popups animation-friendly

    Now, popups will follow this process when showing/hiding:
    
    showPopup():
     1. Move the popup to the top layer, and remove the UA display:none
        style.
     2. Update style. (Transition initial style can be specified in this
        state.)
     3. Set the :top-layer pseudo class.
     4. Update style. (Animations/transitions happen here.)
    
    hidePopup():
     1. Capture any already-running animations via getAnimations().
     2. Remove the :top-layer pseudo class.
     3. Update style. (Animations/transitions start here.)
     4. If the hidePopup() call is not due to a "force out" situation,
        getAnimations() again, remove any from step #1, and then wait here
        until all of them finish or are cancelled.
     4. Remove the popup from the top layer, and add the UA display:none
        style.
     5. Update style.
    
    See this issue for more details:
      openui/open-ui#335
    
    Bug: 1307772
    Change-Id: Ia20eb6e9533c1a0b1029ca1279d42fe2648300af
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3688871
    Reviewed-by: Robert Flack <[email protected]>
    Commit-Queue: Mason Freed <[email protected]>
    Cr-Commit-Position: refs/heads/main@{#1014235}
    mfreed7 authored and chromium-wpt-export-bot committed Jun 15, 2022
    Configuration menu
    Copy the full SHA
    cdc0cdc View commit details
    Browse the repository at this point in the history